chore(deps): bump go to 1.25 everywhere (#3572)

* chore(go): bump to Go1.25

* fix: deprecation comments

* chore(ci): remove go version exclusions

* fix: lint

* fix(model-runner): lint

* fix(lint): exclude modulegen internal packages

* fix(lint): exclude more internal packages

* fix: lint

* fix: lint

* fix: lint

* fix: lint

* fix: golang version in test Dockerfiles

Author: mdelapenya

.devcontainer/devcontainer.json

@@ -2,7 +2,7 @@
 // README at: https://github.com/devcontainers/templates/tree/main/src/go
 {
 	"name": "Go",
-	"image": "mcr.microsoft.com/devcontainers/go:1.24-trixie",
+	"image": "mcr.microsoft.com/devcontainers/go:1.25-trixie",
 
 	// Features to add to the dev container. More info: https://containers.dev/features.
 	// "features": {},

.github/workflows/ci-lint-go.yml

@@ -30,35 +30,10 @@ jobs:
             cache-dependency-path: "${{ inputs.project-directory == '' && '.' || inputs.project-directory }}/go.sum"
         id: go
 
-      - name: Determine golangci-lint version
-        id: linter-version
-        working-directory: ./${{ inputs.project-directory == '' && '.' || inputs.project-directory }}
-        shell: bash
-        run: |
-          # golangci-lint must be built with a Go version >= the module's go directive.
-          MODULE_GO_VERSION=$(grep '^go ' go.mod | awk '{print $2}')
-          MODULE_MAJOR_MINOR=$(echo "${MODULE_GO_VERSION}" | grep -oE '^[0-9]+\.[0-9]+')
-
-          case "${MODULE_MAJOR_MINOR}" in
-            1.24)
-              LINTER_VERSION=v2.0.2
-              ;;
-            1.25)
-              LINTER_VERSION=v2.9.0
-              ;;
-            *)
-              echo "::error::No golangci-lint version mapped for Go ${MODULE_GO_VERSION}. Please update ci-lint-go.yml."
-              exit 1
-              ;;
-          esac
-
-          echo "version=${LINTER_VERSION}" >> "$GITHUB_OUTPUT"
-          echo "Module requires Go ${MODULE_GO_VERSION}, using golangci-lint ${LINTER_VERSION}"
-
       - name: golangci-lint
         uses: golangci/golangci-lint-action@1481404843c368bc19ca9406f87d6e0fc97bdcfd # v7.0.0
         with:
-          version: ${{ steps.linter-version.outputs.version }}
+          version: v2.9.0
           # Optional: working directory, useful for monorepos
           working-directory: ${{ inputs.project-directory }}
 

.github/workflows/ci-test-go.yml

@@ -72,34 +72,11 @@ jobs:
             cache-dependency-path: '${{ inputs.project-directory }}/go.sum'
         id: go
 
-      - name: Check Go version compatibility
-        id: go-compat
-        working-directory: ./${{ inputs.project-directory == '' && '.' || inputs.project-directory }}
-        shell: bash
-        run: |
-          # Read the minimum Go version required by the module
-          MODULE_GO_VERSION=$(grep '^go ' go.mod | awk '{print $2}')
-          RUNNER_GO_VERSION=$(go env GOVERSION | sed 's/^go//')
-          echo "Module requires Go ${MODULE_GO_VERSION}, runner has Go ${RUNNER_GO_VERSION}"
-
-          # Extract major.minor for comparison
-          MODULE_MAJOR_MINOR=$(echo "${MODULE_GO_VERSION}" | grep -oE '^[0-9]+\.[0-9]+')
-          RUNNER_MAJOR_MINOR=$(echo "${RUNNER_GO_VERSION}" | grep -oE '^[0-9]+\.[0-9]+')
-
-          if [ "$(printf '%s\n' "${MODULE_MAJOR_MINOR}" "${RUNNER_MAJOR_MINOR}" | sort -V | head -n1)" = "${MODULE_MAJOR_MINOR}" ]; then
-            echo "compatible=true" >> $GITHUB_OUTPUT
-          else
-            echo "compatible=false" >> $GITHUB_OUTPUT
-            echo "::warning::Skipping tests: module requires Go ${MODULE_GO_VERSION} but runner has Go ${RUNNER_GO_VERSION}"
-          fi
-
       - name: ensure compilation
-        if: steps.go-compat.outputs.compatible == 'true'
         working-directory: ./${{ inputs.project-directory }}
         run: go build ./...
 
       - name: Install dependencies
-        if: steps.go-compat.outputs.compatible == 'true'
         shell: bash
         run: |
           SCRIPT_PATH="./.github/scripts/${{ inputs.project-directory }}/install-dependencies.sh"
@@ -111,25 +88,23 @@ jobs:
 
       # Setup Testcontainers Cloud Client right before your Testcontainers tests
       - name: Setup Testcontainers Cloud Client
-        if: ${{ steps.go-compat.outputs.compatible == 'true' && inputs.testcontainers-cloud }}
+        if: ${{ inputs.testcontainers-cloud }}
         uses: atomicjar/testcontainers-cloud-setup-action@c335bdbb570ec7c48f72c7d450c077f0a002293e # v1.3
         with:
           token: ${{ secrets.TCC_TOKEN }}
 
       - name: go test
-        if: steps.go-compat.outputs.compatible == 'true'
         working-directory: ./${{ inputs.project-directory }}
         timeout-minutes: 30
         run: make test-unit
 
       - name: Run checker
-        if: steps.go-compat.outputs.compatible == 'true'
         run: |
             ./scripts/check_environment.sh
 
       # (Optionally) When you don't need Testcontainers Cloud anymore, you could terminate sessions eagerly
       - name: Terminate Testcontainers Cloud Client active sessions
-        if: ${{ steps.go-compat.outputs.compatible == 'true' && inputs.testcontainers-cloud }}
+        if: ${{ inputs.testcontainers-cloud }}
         uses: atomicjar/testcontainers-cloud-setup-action@c335bdbb570ec7c48f72c7d450c077f0a002293e # v1.3
         with:
           action: terminate
@@ -138,12 +113,12 @@ jobs:
         uses: test-summary/action@31493c76ec9e7aa675f1585d3ed6f1da69269a86 # v2.4
         with:
             paths: "**/${{ inputs.project-directory }}/TEST-unit*.xml"
-        if: ${{ always() && steps.go-compat.outputs.compatible == 'true' }}
+        if: always()
 
       - name: Decide if Sonar must be run
-        if: ${{ steps.go-compat.outputs.compatible == 'true' && matrix.platform == 'ubuntu-latest' }}
+        if: ${{ matrix.platform == 'ubuntu-latest' }}
         run: |
-          if [[ "1.24.x" == "${{ inputs.go-version }}" ]] && \
+          if [[ "1.25.x" == "${{ inputs.go-version }}" ]] && \
              [[ "true" != "${{ inputs.rootless-docker }}" ]] && \
              [[ "true" != "${{ inputs.testcontainers-cloud }}" ]] && \
              [[ "true" != "${{ inputs.ryuk-disabled }}" ]] && \
@@ -153,7 +128,7 @@ jobs:
           fi
 
       - name: Set Sonar Cloud environment variables
-        if: ${{ steps.go-compat.outputs.compatible == 'true' && env.SHOULD_RUN_SONAR == 'true' }}
+        if: ${{ env.SHOULD_RUN_SONAR == 'true' }}
         run: |
           echo "PROJECT_VERSION=$(grep 'latest_version' mkdocs.yml | cut -d':' -f2 | tr -d ' ')" >> $GITHUB_ENV
           if [ "${{ inputs.project-directory }}" == "" ]; then
@@ -169,7 +144,7 @@ jobs:
           fi
 
       - name: SonarQube Scan
-        if: ${{ steps.go-compat.outputs.compatible == 'true' && env.SHOULD_RUN_SONAR == 'true' }}
+        if: ${{ env.SHOULD_RUN_SONAR == 'true' }}
         uses: SonarSource/sonarqube-scan-action@aa494459d7c39c106cc77b166de8b4250a32bb97 # v5.1.0
         env:
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

.github/workflows/ci.yml

@@ -61,7 +61,7 @@ jobs:
       # We don't want to fail the build the soonest but identify which modules passed and failed.
       fail-fast: false
       matrix:
-        go-version: [1.24.x, 1.25.x]
+        go-version: [1.25.x, 1.26.x]
         module: ${{ fromJSON(needs.detect-modules.outputs.modules) }}
     permissions:
       contents: read  # for actions/checkout to fetch code
@@ -88,7 +88,7 @@ jobs:
       # We don't want to fail the build the soonest but identify which modules passed and failed.
       fail-fast: false
       matrix:
-        go-version: [1.24.x, 1.25.x]
+        go-version: [1.25.x, 1.26.x]
     uses: ./.github/workflows/ci-test-go.yml
     with:
       go-version: ${{ matrix.go-version }}
@@ -109,7 +109,7 @@ jobs:
     name: "Test with reaper off"
     strategy:
       matrix:
-        go-version: [1.24.x, 1.25.x]
+        go-version: [1.25.x, 1.26.x]
     uses: ./.github/workflows/ci-test-go.yml
     with:
       go-version: ${{ matrix.go-version }}
@@ -130,7 +130,7 @@ jobs:
     name: "Test with Rootless Docker"
     strategy:
       matrix:
-        go-version: [1.24.x, 1.25.x]
+        go-version: [1.25.x, 1.26.x]
     uses: ./.github/workflows/ci-test-go.yml
     with:
       go-version: ${{ matrix.go-version }}

.golangci.yml

@@ -23,6 +23,27 @@ linters:
     - thelper
     - usestdlibvars
   exclusions:
+    rules:
+      - linters:
+          - revive
+        path: "^exec/"
+        text: "var-naming: avoid package names that conflict with Go standard library package names"
+      - linters:
+          - revive
+        path: "^log/"
+        text: "var-naming: avoid package names that conflict with Go standard library package names"
+      - linters:
+          - revive
+        path: "modulegen/internal/(context|template)/"
+        text: "var-naming: avoid package names that conflict with Go standard library package names"
+      - linters:
+          - revive
+        path: "internal/sdk/types/"
+        text: "var-naming: avoid meaningless package names"
+      - linters:
+          - revive
+        path: "gcloud/internal/shared/"
+        text: "var-naming: avoid meaningless package names"
     presets:
       - comments
       - common-false-positives

AI.md

@@ -14,15 +14,15 @@ This is a **Go monorepo** containing:
 ## Environment Setup
 
 ### Go Version
-- **Required**: Go 1.24.7
+- **Required**: Go 1.25.7
 - **Tool**: Use [gvm](https://github.com/andrewkroh/gvm) for version management
 - **CRITICAL**: Always run this before ANY Go command:
   ```bash
   # For Apple Silicon (M1/M2/M3)
-  eval "$(gvm 1.24.7 --arch=arm64)"
+  eval "$(gvm 1.25.7 --arch=arm64)"
 
   # For Intel/AMD (x86_64)
-  eval "$(gvm 1.24.7 --arch=amd64)"
+  eval "$(gvm 1.25.7 --arch=amd64)"
   ```
 
 ### Project Structure
@@ -171,14 +171,14 @@ func Run(ctx context.Context, img string, opts ...testcontainers.ContainerCustom
 ### When Tests Fail
 1. **Read the error message carefully** - it usually tells you exactly what's wrong
 2. **Check if it's a lint issue** - run `make pre-commit` first
-3. **Verify Go version** - ensure using Go 1.24.7
+3. **Verify Go version** - ensure using Go 1.25.7
 4. **Check Docker** - some tests require Docker daemon running
 
 ## Common Pitfalls to Avoid
 
 ### Code Issues
 - ❌ Using interface types as return values
-- ❌ Forgetting to run `eval "$(gvm 1.24.7 --arch=arm64)"`
+- ❌ Forgetting to run `eval "$(gvm 1.25.7 --arch=arm64)"`
 - ❌ Not handling errors from built-in options
 - ❌ Using module-specific container names (`PostgresContainer`)
 - ❌ Calling `.Customize()` method instead of direct function call

commons-test.mk

@@ -6,7 +6,7 @@ define go_install
 endef
 
 $(GOBIN)/golangci-lint:
-	$(call go_install,github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.0.2)
+	$(call go_install,github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.9.0)
 
 $(GOBIN)/gotestsum:
 	$(call go_install,gotest.tools/gotestsum@latest)

container.go

@@ -28,8 +28,9 @@ import (
 	"github.com/testcontainers/testcontainers-go/wait"
 )
 
+// Deprecated: Use [Container]
+//
 // DeprecatedContainer shows methods that were supported before, but are now deprecated
-// Deprecated: Use Container
 type DeprecatedContainer interface {
 	GetHostEndpoint(ctx context.Context, port string) (string, string, error)
 	GetIPAddress(ctx context.Context) (string, error)

docs/system_requirements/ci/aws_codebuild.md

@@ -11,7 +11,7 @@ version: 0.2
 phases:
   install:
     runtime-versions:
-      golang: 1.24
+      golang: 1.25
   build:
     commands:
       - go test ./...

docs/system_requirements/ci/circle_ci.md

@@ -57,7 +57,7 @@ workflows:
       - tests:
           matrix:
             parameters:
-              go-version: ["1.24.7", "1.25.1"]
+              go-version: ["1.25.7", "1.26.1"]
 
 ```