fix: skip nil strategies in wait.ForAll#3032
Merged
mdelapenya merged 5 commits intoMar 28, 2025
Merged
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stevenh
requested changes
Mar 27, 2025
* main: chore: prepare for next minor development cycle (0.37.0) chore: use new version (v0.36.0) in modules and examples chore: dockerise docs build (testcontainers#3060) chore(deps): bump golang.org/x/net from 0.23.0 to 0.36.0 in /modules/dynamodb (testcontainers#3059) chore(deps): bump github.com/magiconair/properties from 1.8.7 to 1.8.9 (testcontainers#3057) chore(deps): bump golangci/golangci-lint-action from 6.3.0 to 6.5.2 (testcontainers#3052) chore(deps): bump golang.org/x/sys from 0.28.0 to 0.31.0 (testcontainers#3056) chore(deps): bump actions/setup-go from 5.3.0 to 5.4.0 (testcontainers#3054) chore(deps): bump golang.org/x/net in /modules/scylladb (testcontainers#3058) chore(deps): bump github/codeql-action from 3.28.11 to 3.28.12 (testcontainers#3053) chore(deps): bump golang.org/x/net in /modules/databend (testcontainers#3055) feat(azure)!: add Azurite, EventHubs and ServiceBus in the new Azure module, deprecating the old Azurite module (testcontainers#3008) fix: update script path in chmod fix: update sonar script path (testcontainers#3045) chore(ci): manage Sonar projects from Github actions (testcontainers#3039) chore(deps): bump github.com/docker/buildx in /modules/compose (testcontainers#3043) chore(deps): bump github.com/containerd/containerd/v2 (testcontainers#3042) deps(compose): bump compose to v2.34.0 and compose-go to v2.4.9 (testcontainers#3041) chore(deps): bump golang.org/x/net in /modules/yugabytedb (testcontainers#3040) chore(deps)!: bump github.com/docker/docker from 27.1.1+incompatible to 28.0.1+incompatible (testcontainers#3017)
stevenh
requested changes
Mar 28, 2025
Contributor
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Looking good just the lint failures to fix.
stevenh
approved these changes
Mar 28, 2025
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Mar 28, 2025
* main: fix: skip nil strategies in wait.ForAll (testcontainers#3032) chore: prepare for next minor development cycle (0.37.0) chore: use new version (v0.36.0) in modules and examples chore: dockerise docs build (testcontainers#3060)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR skips nil wait strategies in case some downstream consumer uses the wait.ForAll without checking the validity of all the straegies in the list.
A clear example is building a list of strategies depending on certain conditions, and using forAll multiple times.
Why is it important?
Avoid runtime panics