Skip to content

fix: close temp file handle before removal #3672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdelapenya merged 3 commits into from
May 7, 2026
+10 −0
Merged

fix: close temp file handle before removal #3672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39d8f33
fix(dind): close temp file handle before removal
acouvreur May 7, 2026
4ea9a69
fix(k3s): close temp file handle before removal
acouvreur May 7, 2026
f8e88af
Merge branch 'main' into fix/dind-load-image-windows-file-lock
acouvreur May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions modules/dind/dind.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ func (c *Container) LoadImage(ctx context.Context, image string) (err error) {
if err != nil {
return fmt.Errorf("create temporary images file: %w", err)
}
// Close the file handle immediately: SaveImages and CopyFileToContainer
// open the file by name.
if err = imagesTar.Close(); err != nil {
return fmt.Errorf("close temporary images file: %w", err)
}
defer func() {
err = errors.Join(err, os.Remove(imagesTar.Name()))
}()
Expand Down
5 changes: 5 additions & 0 deletions modules/k3s/k3s.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,11 @@ func (c *K3sContainer) LoadImagesWithOpts(ctx context.Context, images []string,
if err != nil {
return fmt.Errorf("creating temporary images file %w", err)
}
// Close the file handle immediately: SaveImages and CopyFileToContainer
// open the file by name.
if err = imagesTar.Close(); err != nil {
return fmt.Errorf("close temporary images file: %w", err)
}
defer func() {
_ = os.Remove(imagesTar.Name())
}()
Expand Down
Loading