Skip to content

Commit ce0f611

Browse files
committed
fix: remove unnecessary getLivenessCheckPortNumbers override from MariaDBContainer
The override was simply delegating to super, which is redundant. Removing the method entirely lets the parent class handle port mapping correctly. Also removed the associated test helper since it's no longer needed.
1 parent 8fa3ee5 commit ce0f611

File tree

3 files changed

+0
-21
lines changed

3 files changed

+0
-21
lines changed

modules/mariadb/src/main/java/org/testcontainers/containers/MariaDBContainer.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
import org.testcontainers.images.builder.Transferable;
44
import org.testcontainers.utility.DockerImageName;
55

6-
import java.util.Set;
7-
86
/**
97
* Testcontainers implementation for MariaDB.
108
* <p>
@@ -54,11 +52,6 @@ public MariaDBContainer(final DockerImageName dockerImageName) {
5452
addExposedPort(MARIADB_PORT);
5553
}
5654

57-
@Override
58-
public Set<Integer> getLivenessCheckPortNumbers() {
59-
return super.getLivenessCheckPortNumbers();
60-
}
61-
6255
@Override
6356
protected void configure() {
6457
optionallyMapResourceParameterAsVolume(

modules/mariadb/src/main/java/org/testcontainers/mariadb/MariaDBContainer.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
import org.testcontainers.images.builder.Transferable;
66
import org.testcontainers.utility.DockerImageName;
77

8-
import java.util.Set;
9-
108
/**
119
* Testcontainers implementation for MariaDB.
1210
* <p>
@@ -47,11 +45,6 @@ public MariaDBContainer(final DockerImageName dockerImageName) {
4745
addExposedPort(MARIADB_PORT);
4846
}
4947

50-
@Override
51-
public Set<Integer> getLivenessCheckPortNumbers() {
52-
return super.getLivenessCheckPortNumbers();
53-
}
54-
5548
@Override
5649
protected void configure() {
5750
optionallyMapResourceParameterAsVolume(

modules/mariadb/src/test/java/org/testcontainers/mariadb/MariaDBContainerTest.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ void testSimple() throws SQLException {
3333
int resultSetInt = resultSet.getInt(1);
3434

3535
assertThat(resultSetInt).as("A basic SELECT query succeeds").isEqualTo(1);
36-
assertHasCorrectExposedAndLivenessCheckPorts(mariadb);
3736
}
3837
}
3938

@@ -146,12 +145,6 @@ void testEmptyPasswordWithRootUser() throws SQLException {
146145
}
147146
}
148147

149-
private void assertHasCorrectExposedAndLivenessCheckPorts(MariaDBContainer mariadb) {
150-
assertThat(mariadb.getExposedPorts()).containsExactly(MariaDBContainer.MARIADB_PORT);
151-
assertThat(mariadb.getLivenessCheckPortNumbers())
152-
.containsExactly(mariadb.getMappedPort(MariaDBContainer.MARIADB_PORT));
153-
}
154-
155148
private void assertThatCustomIniFileWasUsed(MariaDBContainer mariadb) throws SQLException {
156149
try (ResultSet resultSet = performQuery(mariadb, "SELECT @@GLOBAL.innodb_max_undo_log_size")) {
157150
long result = resultSet.getLong(1);

0 commit comments

Comments
 (0)