Commit ea5e2a7
committed
fix: return mapped port from MariaDBContainer.getLivenessCheckPortNumbers
MariaDBContainer.getLivenessCheckPortNumbers() returned the hardcoded
internal port (3306) instead of the mapped external port. This was
originally fixed for other containers in a prior PR but MariaDB was
missed. The new MariaDBContainer class then copied the same buggy
implementation.
Delegate to super.getLivenessCheckPortNumbers() which correctly maps
internal ports to external mapped ports via getMappedPort().
Applied to both:
- org.testcontainers.mariadb.MariaDBContainer (current)
- org.testcontainers.containers.MariaDBContainer (deprecated)1 parent 326987f commit ea5e2a7
File tree
3 files changed
+9
-4
lines changed- modules/mariadb/src
- main/java/org/testcontainers
- containers
- mariadb
- test/java/org/testcontainers/mariadb
3 files changed
+9
-4
lines changedLines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
| |||
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
60 | | - | |
| 59 | + | |
61 | 60 | | |
62 | 61 | | |
63 | 62 | | |
| |||
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
| |||
50 | 49 | | |
51 | 50 | | |
52 | 51 | | |
53 | | - | |
| 52 | + | |
54 | 53 | | |
55 | 54 | | |
56 | 55 | | |
| |||
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
145 | 146 | | |
146 | 147 | | |
147 | 148 | | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
148 | 155 | | |
149 | 156 | | |
150 | 157 | | |
| |||
0 commit comments