Upgrade docker-java to 3.5.0#10186
Closed
LarsSven wants to merge 1 commit intotestcontainers:mainfrom
Closed
Conversation
Member
|
Hi, thanks for your contribution. We have been managing this manually and given the updates on docker-java 3.5.0, we are not updating the version right away because of compatibility. Instead, we will wait some months to do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that dependabot wasn't proposing a docker-java upgrade, and that this one is always manually proposed. We would really like this upgrade so thought I would propose it.
The reason we care about this is because we use Quarkus, and in Quarkus docker-java is always enforced to have the same version as testcontainers-java's docker-java version. So we can't upgrade docker-java until testcontainers-java upgrades to the new version.