[Bug]: VaultContainer doesn't work on GitLab

[mvmn]

Module

Vault

Testcontainers version

1.17.6

Using the latest Testcontainers version?

Yes

Host OS

Linux

Host Arch

x86

Docker version

20.10.18

What happened?

Vault container startup fails in Bitbucket Pipelines. Cap add is forbidden in Bitbucket Pipelines - but VaultContainer uses the deprecated api to set --cap-add via create container command modifier:
withCreateContainerCmdModifier(cmd -> cmd.withCapAdd(Capability.IPC_LOCK)); (see line 58 here - https://github.com/testcontainers/testcontainers-java/blob/main/modules/vault/src/main/java/org/testcontainers/vault/VaultContainer.java )

And there is no possibility to override this.

Relevant log output

[Test worker] INFO  🐳 [vault:1.12.2] - Creating container for image: vault:1.12.2
[Test worker] ERROR 🐳 [vault:1.12.2] - Could not start container
    com.github.dockerjava.api.exception.DockerException: Status 403: {"message":"authorization denied by plugin pipelines: --cap-add is not allowed"}

Additional Information

No response

[ClaudenirFreitas]

GitLab or Bitbucket? 🤔

[ClaudenirFreitas]

I just tested with this approach and it worked!

@Testcontainers
class Issue6623 {

    @Container
    public VaultContainer<?> vaultContainer = new VaultContainerFix()
            .withSecretInVault("secret/issue6623", "foo=bar")
            .withVaultToken("default");

    @Test
    void retrieveValue() throws IOException, InterruptedException {
        var result = vaultContainer.execInContainer(
                "vault",
                "kv",
                "get",
                "--field=foo",
                "secret/issue6623"
        );
        assertEquals("bar", result.getStdout());
    }

}

class VaultContainerFix extends VaultContainer<VaultContainerFix> {

    public VaultContainerFix() {
        super(DockerImageName.parse("hashicorp/vault"));
        withCreateContainerCmdModifier(cmd -> cmd.withCapAdd(Collections.emptyList()));
    }

}

As you said, the cmd.withCapAdd(Capability.IPC_LOCK) is the issue...

[eddumelendez]

Testcontainers Vault module is configured as suggested in the docs. I understand some vendors have a specific configuration and the previous code snippet is a valid approach to tackle those configurations.