Skip to content

Feature/postponed env read#8824

Closed
simpletasks wants to merge 19 commits intotestcontainers:mainfrom
simpletasks:feature/postponed-env-read
Closed

Feature/postponed env read#8824
simpletasks wants to merge 19 commits intotestcontainers:mainfrom
simpletasks:feature/postponed-env-read

Conversation

@simpletasks
Copy link
Copy Markdown
Contributor

Related to issue #8823

Replace field declaration in ContainerDef: Map<String, String> envVars = new HashMap<>();
with Map<String, Supplier<String>> envVars = new HashMap<>();

@simpletasks
Copy link
Copy Markdown
Contributor Author

I added a positive test showing a combination of .dependsOn() and .withEnv() when the dependent container depends on the mapped port of another container.

@simpletasks
Copy link
Copy Markdown
Contributor Author

I added a negative test showing failure in test setup using @container annotation and a combination of .dependsOn() and .withEnv() methods when the dependent container depends on the mapped port of another container.

@eddumelendez
Copy link
Copy Markdown
Member

Hi, thanks for your contributions. The proposal is introducing additional changes that are not expected.

@simpletasks
Copy link
Copy Markdown
Contributor Author

Hi @eddumelendez can you comment about complete proposal here? IMO this part is missing for 'Container' annotation and how I understand the logic expected from 'Container' annotation.
About 'additional changes', do they make whole solution more robust or introduce some constraints?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants