-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add support for initialization scripts #11331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
taole33
wants to merge
8
commits into
testcontainers:main
Choose a base branch
from
taole33:feature/issue-3066-mongodb-init-script
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
53b3869
feat(module/mongodb): Add support for initialization scripts
taole33 e2adfb1
style: Apply code formatting
taole33 e81a2ac
fix(module/mongodb):move to org.testcontainers.mongodb.MongoDBContainer
taole33 35b753b
Fix withInitScript compatibility with ReplicaSet and Sharding modes
taole33 488b5fa
Fix edgecases test
taole33 b7ca531
fix: Address review comments
taole33 d868b95
fix: Address review comments
taole33 4c3c477
Merge branch 'main' into feature/issue-3066-mongodb-init-script
eddumelendez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
modules/mongodb/src/test/java/org/testcontainers/mongodb/MongoDBInitScriptTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package org.testcontainers.containers; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.time.Duration; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| class MongoDBInitScriptTest { | ||
|
|
||
| @Test | ||
| void testWithInitScript() { | ||
| // Start the container using try-with-resources to ensure it closes automatically | ||
| try ( | ||
| MongoDBContainer mongoDB = new MongoDBContainer("mongo:4.0.10") | ||
| // Configure the init script. This triggers a restart inside the container, | ||
| // so the container must wait for the second "waiting for connections" log message. | ||
| .withInitScript("init.js") | ||
| .withStartupTimeout(Duration.ofSeconds(30)) | ||
| ) { | ||
| mongoDB.start(); | ||
|
|
||
| // Assert that the container started successfully | ||
| assertThat(mongoDB.isRunning()).isTrue(); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| db.createCollection("test_collection"); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
org.testcontainers.containers.MongoDBContaineris deprecated. can you moved toorg.testcontainers.mongodb.MongoDBContainer?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved to
org.testcontainers.mongodb.MongoDBContainer.Also, For the tests, instead of creating a new file named
MongoDBInitScriptTest.java, I added the test cases directly toMongoDBContainerTest.java.