[couchbase] Only expose ports for enabled services#4595
Merged
eddumelendez merged 2 commits intotestcontainers:masterfrom Aug 23, 2022
Merged
[couchbase] Only expose ports for enabled services#4595eddumelendez merged 2 commits intotestcontainers:masterfrom
eddumelendez merged 2 commits intotestcontainers:masterfrom
Conversation
daschl
changed the title
Member
kiview
approved these changes
Oct 22, 2021
Member
kiview
left a comment
kiview
left a comment
There was a problem hiding this comment.
LGTM after resolving the conflicts.
This changeset is a minor cleanup, but it makes sense to only actually expose the ports for the services which are enabled and not all of them all the time.
Member
Author
Member
Author
|
The failing test is unrelated I think. |
Member
|
Yeah, that was a weird one. I re-triggered the build, just to be sure. |
Member
|
Eventing ports have been added and conflicts were resolved. |
Member
|
Thanks for the PR @daschl ! and sorry about the long wait but it is merged now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on your previous PR comment @kiview, this one is best merged after the analytics one since I built it on top.