Skip to content

Commit 898cad1

Browse files
Merge branch 'main' into dependabot/github_actions/actions-30a030d1d1
2 parents a86da34 + bffab75 commit 898cad1

28 files changed

Lines changed: 178 additions & 43 deletions

File tree

AGENTS.md

Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
# AGENTS.md
2+
3+
## Purpose
4+
5+
This is a working guide for contributors and coding agents in this repository.
6+
It captures practical rules that prevent avoidable CI and PR churn.
7+
8+
## Development Expectations
9+
10+
- If a public API changes, update the relevant docs in the same PR.
11+
- If new types are made part of the public API, export them from the package's `index.ts` in the same PR.
12+
- If new learnings or misunderstandings are discovered, propose an `AGENTS.md` update in the same PR.
13+
- Tests should verify observable behavior changes, not only internal/config state.
14+
- Example: for a security option, assert a real secure/insecure behavior difference.
15+
16+
## Permission and Escalation
17+
18+
- `npm install` requires escalated permissions for outbound network access to npm registries.
19+
- `npm test` commands should b`e run with escalation so tests can access the Docker socket.
20+
21+
### Escalation hygiene
22+
23+
- Use specific commands and clear justifications.
24+
- Prefer narrow reruns rather than broad full-suite reruns when iterating.
25+
26+
## PR Process
27+
28+
1. Start from `main`.
29+
2. Create a branch prefixed with `codex/`.
30+
3. Implement scoped changes only.
31+
4. Run required checks: `npm run format`, `npm run lint`, and targeted tests.
32+
5. Verify git diff only contains intended files. If changes are still being discussed, share the diff and get user approval before committing or pushing.
33+
6. Commit with focused message(s), using `git commit --no-verify`.
34+
7. Push branch. Ask for explicit user permission before any force push.
35+
8. Open PR against `main` using a human-readable title (no `feat(...)` / `fix(...)` prefixes).
36+
9. Before posting any comment on GitHub issues or PRs, share the proposed message with the user and get explicit approval.
37+
10. Add labels for both change type and semantic version impact.
38+
11. Ensure PR body includes:
39+
- summary of changes
40+
- verification commands run
41+
- test results summary
42+
- `Closes #<issue>`
43+
44+
## Labels
45+
46+
### Change type
47+
48+
- `enhancement`
49+
- `bug`
50+
- `dependencies`
51+
- `documentation`
52+
- `maintenance`
53+
54+
### Semver impact
55+
56+
- `major`
57+
- `minor`
58+
- `patch`
59+
60+
### Common mappings
61+
62+
- backward-compatible feature: `enhancement` + `minor`
63+
- backward-compatible bug fix: `bug` + `patch`
64+
- breaking change: type label + `major`
65+
- docs-only change: `documentation` + usually `patch`
66+
- dependency update: `dependencies` + impact label based on user-facing effect
67+
68+
## Practical Note
69+
70+
- Recheck `package-lock.json` after `npm install` for unrelated drift and revert unrelated changes.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
FROM mcr.microsoft.com/azure-messaging/servicebus-emulator:1.1.2
1+
FROM mcr.microsoft.com/azure-messaging/servicebus-emulator:2.0.0
22
FROM mcr.microsoft.com/mssql/server:2025-latest
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
FROM chromadb/chroma:1.4.0
2-
FROM ollama/ollama:0.13.5
1+
FROM chromadb/chroma:1.5.0
2+
FROM ollama/ollama:0.16.1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
FROM clickhouse/clickhouse-server:25.12-alpine
1+
FROM clickhouse/clickhouse-server:26.1-alpine
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
FROM cockroachdb/cockroach:v25.4.2
1+
FROM cockroachdb/cockroach:v25.4.4
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
FROM couchbase/server:enterprise-7.0.2
2-
FROM couchbase/server:community-7.0.2
1+
FROM couchbase/server:enterprise-8.0.0
2+
FROM couchbase/server:community-8.0.0

packages/modules/couchbase/src/couchbase-container.ts

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -301,33 +301,46 @@ export class CouchbaseContainer extends GenericContainer {
301301

302302
body.set("hostname", container.getHost());
303303
body.set("mgmt", container.getMappedPort(PORTS.MGMT_PORT).toString());
304-
body.set("mgmtSSL", container.getMappedPort(PORTS.MGMT_SSL_PORT).toString());
304+
if (this.isEnterprise) {
305+
body.set("mgmtSSL", container.getMappedPort(PORTS.MGMT_SSL_PORT).toString());
306+
}
305307

306308
if (this.enabledServices.has(CouchbaseService.KV)) {
307309
body.set("kv", container.getMappedPort(PORTS.KV_PORT).toString());
308-
body.set("kvSSL", container.getMappedPort(PORTS.KV_SSL_PORT).toString());
309310
body.set("capi", container.getMappedPort(PORTS.VIEW_PORT).toString());
310-
body.set("capiSSL", container.getMappedPort(PORTS.VIEW_SSL_PORT).toString());
311+
312+
if (this.isEnterprise) {
313+
body.set("kvSSL", container.getMappedPort(PORTS.KV_SSL_PORT).toString());
314+
body.set("capiSSL", container.getMappedPort(PORTS.VIEW_SSL_PORT).toString());
315+
}
311316
}
312317

313318
if (this.enabledServices.has(CouchbaseService.QUERY)) {
314319
body.set("n1ql", container.getMappedPort(PORTS.QUERY_PORT).toString());
315-
body.set("n1qlSSL", container.getMappedPort(PORTS.QUERY_SSL_PORT).toString());
320+
if (this.isEnterprise) {
321+
body.set("n1qlSSL", container.getMappedPort(PORTS.QUERY_SSL_PORT).toString());
322+
}
316323
}
317324

318325
if (this.enabledServices.has(CouchbaseService.SEARCH)) {
319326
body.set("fts", container.getMappedPort(PORTS.SEARCH_PORT).toString());
320-
body.set("ftsSSL", container.getMappedPort(PORTS.SEARCH_SSL_PORT).toString());
327+
if (this.isEnterprise) {
328+
body.set("ftsSSL", container.getMappedPort(PORTS.SEARCH_SSL_PORT).toString());
329+
}
321330
}
322331

323332
if (this.enabledServices.has(CouchbaseService.ANALYTICS)) {
324333
body.set("cbas", container.getMappedPort(PORTS.ANALYTICS_PORT).toString());
325-
body.set("cbasSSL", container.getMappedPort(PORTS.ANALYTICS_SSL_PORT).toString());
334+
if (this.isEnterprise) {
335+
body.set("cbasSSL", container.getMappedPort(PORTS.ANALYTICS_SSL_PORT).toString());
336+
}
326337
}
327338

328339
if (this.enabledServices.has(CouchbaseService.EVENTING)) {
329340
body.set("eventingAdminPort", container.getMappedPort(PORTS.EVENTING_PORT).toString());
330-
body.set("eventingSSL", container.getMappedPort(PORTS.EVENTING_SSL_PORT).toString());
341+
if (this.isEnterprise) {
342+
body.set("eventingSSL", container.getMappedPort(PORTS.EVENTING_SSL_PORT).toString());
343+
}
331344
}
332345

333346
const response = await this.doHttpRequest(
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
FROM elasticsearch:9.2.3
1+
FROM elasticsearch:9.3.0

packages/modules/etcd/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
FROM quay.io/coreos/etcd:v3.6.7
1+
FROM quay.io/coreos/etcd:v3.6.8

packages/modules/gcloud/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM gcr.io/google.com/cloudsdktool/google-cloud-cli:555.0.0-emulators
2-
FROM fsouza/fake-gcs-server:1.53.1
1+
FROM gcr.io/google.com/cloudsdktool/google-cloud-cli:556.0.0-emulators
2+
FROM fsouza/fake-gcs-server:1.54.0
33
FROM ghcr.io/goccy/bigquery-emulator:0.6.6
4-
FROM gcr.io/cloud-spanner-emulator/emulator:1.5.48
4+
FROM gcr.io/cloud-spanner-emulator/emulator:1.5.49

0 commit comments

Comments
 (0)