AbstractStartedContainer asyncDispose should call this.stop

[joebowbeer]

@cristianrgreco Shouldn't this call this.stop?

Expected:

  async [Symbol.asyncDispose]() {
    await this.stop();
  }

Actual:

testcontainers-node/packages/testcontainers/src/generic-container/abstract-started-container.ts

Lines 107 to 109 in 504de94

	async [Symbol.asyncDispose]() {
	await this.startedTestContainer[Symbol.asyncDispose]();
	}

Originally posted by @joebowbeer in #1080 (comment)

[cristianrgreco]

@joebowbeer It calls the startedTestContainer's asyncDispose, which calls stop()

[joebowbeer]

Technically, I think it should call its own stop (this.stop), which also calls the startedTestContainer's stop()

In other words, I think its implementation should be the same as that of generic-started-container.

The difference being what happens to overridden methods of AbstractStartedContainer, which is designed to be extended. I'm referring to the overridden methods that are called by this.stop(), and also this.stop itself, if it is overridden.

[cristianrgreco]

You are right, the current behaviour means that when a user calls asyncDispose, any subclasses which override stop are bypassed, as well as their pre/post stop hooks. Thanks for the find! Would you be able to raise a PR?

I noticed as well that this promise in the stop method is not awaited, which could result in other issues..

testcontainers-node/packages/testcontainers/src/generic-container/abstract-started-container.ts

Line 15 in 98a81b3

const stoppedContainer = this.startedTestContainer.stop(options);

Perhaps this could be included in the PR if you're able?

Thanks @joebowbeer

[joebowbeer]

@cristianrgreco I created PR #1203

I think this fixes an issue in StartedAzureServiceBusContainer, where asyncDispose was not previously calling the overridden containerStopped method.

testcontainers-node/packages/modules/azureservicebus/src/azureservicebus-container.ts

Lines 144 to 150 in 252239f

	protected override async containerStopped(): Promise<void> {
	try {
	await this.mssql.stop();
	} finally {
	await this.network.stop();
	}
	}