Add support for running in parallel for distinct UIDs#1276
Add support for running in parallel for distinct UIDs#1276cristianrgreco merged 1 commit intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cristianrgreco
added
enhancement
|
@seanwu1105 I'm sure if I re-ran the failing test it'd pass, but I have not seen this one ever flake. I assume this change has introduced some race condition, which at least affects those tests. Could you have a look? |
|
Hey @cristianrgreco, I could not figure out the root cause for that issue in CI, unfortunately. The lock file change itself is unlikely to be the root cause. In CI, all processes run as the same user so the lock file with the UID still provides the exact same cross-process synchronization as the old one. If you believe the PR is dangerous and could still be the cause potentially, feel free to close it. |
|
I've had a look and agree the test flaking isn't related to this change, will merge this shortly. |
cristianrgreco
changed the title
2 participants
Currently, the lock file is created in
/tmpwith a constant nametestcontainer-node.lock. This makes it global per machine. This PR change this to make the lock file per user by including the name with user ID.