Fix lambda container is dropped by ryuk (#848)#922
Merged
cristianrgreco merged 1 commit intotestcontainers:mainfrom Mar 11, 2025
Merged
Fix lambda container is dropped by ryuk (#848)#922cristianrgreco merged 1 commit intotestcontainers:mainfrom
cristianrgreco merged 1 commit intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cristianrgreco
approved these changes
Mar 11, 2025
cristianrgreco
added
bug
Contributor
Author
|
@cristianrgreco many thanks for your approval and reactivity. Is it possible to create a new 10.18.1 release with this fix, please ? |
Collaborator
|
@julienboulay np, thank you for the PR! I've merged another PR which was a minor change which hasn't yet been released. Because of that the next version will be 10.19.0. I'll trigger a release once I've merged #921 (includes some dependency updates to address some vulnerabilities) |
vaernion
pushed a commit
to Arbeidstilsynet/brevgen2
that referenced
this pull request
Dec 3, 2025
….20.0 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [testcontainers](https://github.com/testcontainers/testcontainers-node) | devDependencies | minor | [`10.18.0` -> `10.20.0`](https://renovatebot.com/diffs/npm/testcontainers/10.18.0/10.20.0) | --- ### Release Notes <details> <summary>testcontainers/testcontainers-node (testcontainers)</summary> ### [`v10.20.0`](https://github.com/testcontainers/testcontainers-node/releases/tag/v10.20.0) [Compare Source](testcontainers/testcontainers-node@v10.19.0...v10.20.0) #### Changes #### 🚀 Features - Add support for container commit [@​smcroskey](https://github.com/smcroskey) ([#​923](testcontainers/testcontainers-node#923)) #### 🧹 Maintenance - Fix flaky healthcheck timeout test [@​cristianrgreco](https://github.com/cristianrgreco) ([#​930](testcontainers/testcontainers-node#930)) - Fix flaky Selenium test [@​cristianrgreco](https://github.com/cristianrgreco) ([#​929](testcontainers/testcontainers-node#929)) ### [`v10.19.0`](https://github.com/testcontainers/testcontainers-node/releases/tag/v10.19.0) [Compare Source](testcontainers/testcontainers-node@v10.18.0...v10.19.0) #### Changes #### 🚀 Features - Add CockroachDB module [@​leourbina](https://github.com/leourbina) ([#​910](testcontainers/testcontainers-node#910)) #### 🐛 Bug Fixes - Fix lambda container is dropped by ryuk ([#​848](testcontainers/testcontainers-node#848)) [@​julienboulay](https://github.com/julienboulay) ([#​922](testcontainers/testcontainers-node#922)) - Fix PostgreSQL container restart [@​cristianrgreco](https://github.com/cristianrgreco) ([#​914](testcontainers/testcontainers-node#914)) #### 🧹 Maintenance - Migrate from Jest to Vitest [@​cristianrgreco](https://github.com/cristianrgreco) ([#​921](testcontainers/testcontainers-node#921)) - GHA workflow job names [@​cristianrgreco](https://github.com/cristianrgreco) ([#​920](testcontainers/testcontainers-node#920)) - Optimise CI to reduce runners usage, caching NPM modules when needed [@​mdelapenya](https://github.com/mdelapenya) ([#​918](testcontainers/testcontainers-node#918)) - Update docs to demonstrate specifying Qdrant version [@​Anush008](https://github.com/Anush008) ([#​917](testcontainers/testcontainers-node#917)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually on...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #848
Configure the LocalStack container to add sessionId when starting lambda container.
This allows the lambda container to be identified by the reaper and cleaned up on exit.
See Localstack documentation for more details about LAMBDA_DOCKER_FLAGS