Skip to content

Do not replace user-provided Localstack LAMBDA_DOCKER_FLAGS#935

Merged
cristianrgreco merged 2 commits intotestcontainers:mainfrom
florian-nguyen:enhancement/prevent_localstack_overwrite_lambda_docker_flags
Mar 17, 2025
Merged

Do not replace user-provided Localstack LAMBDA_DOCKER_FLAGS#935
cristianrgreco merged 2 commits intotestcontainers:mainfrom
florian-nguyen:enhancement/prevent_localstack_overwrite_lambda_docker_flags

Conversation

@florian-nguyen
Copy link
Copy Markdown
Contributor

@florian-nguyen florian-nguyen commented Mar 17, 2025

Improvement:
Following this fix, prevent sessionId stored in Localstack LAMBDA_DOCKER_FLAGS from being overwritten when other flags are defined.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 17, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 4442912
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/67d8638c89b0a300088f017d
😎 Deploy Preview https://deploy-preview-935--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco cristianrgreco added bug Something isn't working patch Backward compatible bug fix labels Mar 17, 2025
@cristianrgreco cristianrgreco changed the title Improvement append session id to lambda docker flags Do not replace user-provided Localstack LAMBDA_DOCKER_FLAGS Mar 17, 2025
@cristianrgreco cristianrgreco merged commit 6f78dcc into testcontainers:main Mar 17, 2025
18 checks passed
@florian-nguyen
Copy link
Copy Markdown
Contributor Author

@cristianrgreco Thanks for reviewing and approving this MR so quickly! Would you be able to approximately tell when the next version will be released?

@cristianrgreco
Copy link
Copy Markdown
Collaborator

vaernion pushed a commit to Arbeidstilsynet/brevgen2 that referenced this pull request Dec 3, 2025
….21.0

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [testcontainers](https://github.com/testcontainers/testcontainers-node) | devDependencies | minor | [`10.20.0` -> `10.21.0`](https://renovatebot.com/diffs/npm/testcontainers/10.20.0/10.21.0) |

---

### Release Notes

<details>
<summary>testcontainers/testcontainers-node (testcontainers)</summary>

### [`v10.21.0`](https://github.com/testcontainers/testcontainers-node/releases/tag/v10.21.0)

[Compare Source](testcontainers/testcontainers-node@v10.20.0...v10.21.0)

#### Changes

#### 🚀 Features

-   Add ability to set command flags to Gcloud emulators [@&#8203;digital88](https://github.com/digital88) ([#&#8203;926](testcontainers/testcontainers-node#926))
-   Update resource reaper version [@&#8203;loikg](https://github.com/loikg) ([#&#8203;933](testcontainers/testcontainers-node#933))
-   Add cosmos db emulator module [@&#8203;mrtnsch](https://github.com/mrtnsch) ([#&#8203;934](testcontainers/testcontainers-node#934))
-   Add ability to copy archives into containers [@&#8203;zacaj](https://github.com/zacaj) ([#&#8203;932](testcontainers/testcontainers-node#932))

#### 🐛 Bug Fixes

-   Do not replace user-provided Localstack `LAMBDA_DOCKER_FLAGS` [@&#8203;florian-nguyen](https://github.com/florian-nguyen) ([#&#8203;935](testcontainers/testcontainers-node#935))

#### 🧹 Maintenance

-   Upgrade linting libraries [@&#8203;prenaissance](https://github.com/prenaissance) ([#&#8203;931](testcontainers/testcontainers-node#931))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!".

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Related work items: #30372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants