Skip to content

Log stream fix for Podman#968

Merged
cristianrgreco merged 1 commit intomainfrom
log-stream-fix-for-podman
Apr 2, 2025
Merged

Log stream fix for Podman#968
cristianrgreco merged 1 commit intomainfrom
log-stream-fix-for-podman

Conversation

@cristianrgreco
Copy link
Copy Markdown
Collaborator

@cristianrgreco cristianrgreco commented Apr 2, 2025

Podman's API implementation delays resolving the logs Promise until the first chunk of log data is actually sent over the stream when follow: true. If the container never logs anything the Promise never resolves, and the await hangs indefinitely. Docker in contrast resolves the Promise as soon as the streaming connection is established, even before data flows.

This PR creates a pass through stream to act as a proxy which is immediately ready for all callers.

@cristianrgreco cristianrgreco added bug Something isn't working patch Backward compatible bug fix labels Apr 2, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 2, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 3189acb
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/67ed063ed21eee000866f4ea
😎 Deploy Preview https://deploy-preview-968--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco cristianrgreco merged commit 87a5e5e into main Apr 2, 2025
249 checks passed
@cristianrgreco cristianrgreco deleted the log-stream-fix-for-podman branch April 2, 2025 10:06
vaernion pushed a commit to Arbeidstilsynet/brevgen2 that referenced this pull request Dec 3, 2025
….24.0

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [testcontainers](https://github.com/testcontainers/testcontainers-node) | [`10.23.0` -> `10.24.0`](https://renovatebot.com/diffs/npm/testcontainers/10.23.0/10.24.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/testcontainers/10.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/testcontainers/10.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/testcontainers/10.23.0/10.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/testcontainers/10.23.0/10.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>testcontainers/testcontainers-node (testcontainers)</summary>

### [`v10.24.0`](https://github.com/testcontainers/testcontainers-node/releases/tag/v10.24.0)

[Compare Source](testcontainers/testcontainers-node@v10.23.0...v10.24.0)

#### Changes

#### 🚀 Features

-   Add SocatContainer [@&#8203;eddumelendez](https://github.com/eddumelendez) ([#&#8203;964](testcontainers/testcontainers-node#964))

#### 🐛 Bug Fixes

-   Fix healthcheck for Postgis [@&#8203;cristianrgreco](https://github.com/cristianrgreco) ([#&#8203;972](testcontainers/testcontainers-node#972))
-   Log stream fix for Podman [@&#8203;cristianrgreco](https://github.com/cristianrgreco) ([#&#8203;968](testcontainers/testcontainers-node#968))

#### 📦 Dependency Updates

-   Update vitest + npm audit [@&#8203;cristianrgreco](https://github.com/cristianrgreco) ([#&#8203;970](testcontainers/testcontainers-node#970))
-   Bump tar-fs from 3.0.6 to 3.0.7 [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;965](testcontainers/testcontainers-node#965))
-   Bump vite from 6.2.2 to 6.2.4 [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;966](testcontainers/testcontainers-node#966))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!".

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Related work items: #30372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant