Skip to content

Commit 45d17d4

Browse files
learn that dind bug is actually python syntax bug
1 parent 9a9e50a commit 45d17d4

File tree

2 files changed

+38
-40
lines changed

2 files changed

+38
-40
lines changed

.github/workflows/ci-core.yml

Lines changed: 37 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -22,42 +22,40 @@ jobs:
2222
with:
2323
python-version: ${{ matrix.python-version }}
2424
- name: Install Python dependencies
25-
run: poetry install --all-groups
26-
- name: debug dind
27-
run: DIND=1 poetry run pytest core/tests/test_docker_in_docker.py
28-
# - name: Run twine check
29-
# run: rm -f LICENSE.txt && poetry build && poetry run twine check dist/*.tar.gz
30-
# - name: Run tests
31-
# run: make core/tests
32-
# - name: Rename coverage file
33-
# run: mv .coverage .coverage.${{ matrix.python-version}}
34-
# - name: "Save coverage artifact"
35-
# uses: actions/upload-artifact@v4
36-
# with:
37-
# name: "coverage-artifact-${{ matrix.python-version}}"
38-
# include-hidden-files: true
39-
# path: ".coverage.*"
40-
# retention-days: 1
41-
# - name: Run doctests
42-
# run: make core/doctests
43-
#
44-
# coverage-compile:
45-
# needs: "run-tests-and-coverage"
46-
# runs-on: ubuntu-22.04
47-
# steps:
48-
# - uses: actions/checkout@v4
49-
# - name: Set up Python
50-
# uses: ./.github/actions/setup-env
51-
# - name: Install Python dependencies
52-
# run: poetry install --all-extras
53-
# - name: "Download coverage artifacts"
54-
# uses: actions/download-artifact@v4
55-
# with:
56-
# pattern: "coverage-artifact-*"
57-
# merge-multiple: true
58-
# - name: Compile coverage
59-
# run: make coverage
60-
# - name: Upload coverage to Codecov
61-
# uses: codecov/codecov-action@v4
62-
# with:
63-
# token: ${{ secrets.CODECOV_TOKEN }}
25+
run: poetry install --all-extras
26+
- name: Run twine check
27+
run: rm -f LICENSE.txt && poetry build && poetry run twine check dist/*.tar.gz
28+
- name: Run tests
29+
run: make core/tests
30+
- name: Rename coverage file
31+
run: mv .coverage .coverage.${{ matrix.python-version}}
32+
- name: "Save coverage artifact"
33+
uses: actions/upload-artifact@v4
34+
with:
35+
name: "coverage-artifact-${{ matrix.python-version}}"
36+
include-hidden-files: true
37+
path: ".coverage.*"
38+
retention-days: 1
39+
- name: Run doctests
40+
run: make core/doctests
41+
42+
coverage-compile:
43+
needs: "run-tests-and-coverage"
44+
runs-on: ubuntu-22.04
45+
steps:
46+
- uses: actions/checkout@v4
47+
- name: Set up Python
48+
uses: ./.github/actions/setup-env
49+
- name: Install Python dependencies
50+
run: poetry install --all-extras
51+
- name: "Download coverage artifacts"
52+
uses: actions/download-artifact@v4
53+
with:
54+
pattern: "coverage-artifact-*"
55+
merge-multiple: true
56+
- name: Compile coverage
57+
run: make coverage
58+
- name: Upload coverage to Codecov
59+
uses: codecov/codecov-action@v4
60+
with:
61+
token: ${{ secrets.CODECOV_TOKEN }}

core/tests/test_docker_in_docker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from testcontainers.core.utils import is_mac
2323
from testcontainers.core.waiting_utils import wait_for_logs
2424

25-
_DIND_PYTHON_VERSION = (3, 13)
25+
_DIND_PYTHON_VERSION = (3, 10)
2626
logger = logging.getLogger(__name__)
2727

2828

0 commit comments

Comments
 (0)