fix(clickhouse): add HttpWaitStrategy instead of deprecated wait_container_is_ready#962
Merged
alexanderankin merged 4 commits intotestcontainers:mainfrom Apr 3, 2026
Conversation
Contributor
Author
|
@alexanderankin could you review my PR, please |
Tranquility2
added
📦 package: clickhouse
✨ feat
👥 community feat
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
=======================================
Coverage 79.81% 79.81%
=======================================
Files 15 15
Lines 1303 1303
Branches 162 162
=======================================
Hits 1040 1040
Misses 216 216
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tranquility2
changed the title
HttpWaitStrategy instead of deprecated wait_container_is_readyHttpWaitStrategy instead of deprecated wait_container_is_ready
Tranquility2
approved these changes
Apr 3, 2026
Tranquility2
added
🔧 fix
and removed
✨ feat
👥 community feat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Decorator
wait_container_is_readyis deprecated and raiseDeprecationWarningRelated issue: #874
How it was fixed?
Replace the deprecated
wait_container_is_readydecorator withHttpWaitStrategyin theClickHouseContainer