feat!: CopyDataSource from static sources#941
Open
gibbz00 wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
CopyDataSource::Datafrom containing aVec<u8>to aCow<'static, [u8]>, and then provides additionalFrom<{&'static u8,&'static str,String}>implementation for it.The motivation for this breaking change is admittedly mostly aesthetic.
The first change will break compilation for projects that construct
CopyDataSourcedirectly withCopyDataSource::Data(vec). Those usingimpl Into<CopyDataSource>are unaffected by this change. Hopefully, most users constructCopyDataSourcewith the latter alternative.testcontainers-modulesdoes this exclusively.Another alternative could be to extend the enum with a third variant:
This is also a breaking change, but only for those performing pattern matching on
CopyDataSource, to which I assume a lot fewer do.Completely understandable if this PR gets rejected given the questionable gains from such a breaking change ✌️