Skip to content

CHANGELOG.md

Latest commit

 

History

History
407 lines (353 loc) · 42.8 KB

CHANGELOG.md

File metadata and controls

407 lines (353 loc) · 42.8 KB

Change Log

0.33.0 (October 23rd, 2018)

  • enhancement - add new command to clean the server workspace. See #655.
  • enhancement - add Mockito static imports by default. See #679.
  • bug fix - fixed "Busy loop " when running Java 11. See #664.
  • bug fix - fixed Maven diagnostics showing up and disappearing on save. See #669.
  • bug fix - ignore multiple code lenses for lombok generated methods. See #674.

0.32.0 (October 2nd, 2018)

  • enhancement - new Java 11 support for Maven, Gradle and Eclipse projects. See #625 and #653.
  • enhancement - cascade "Update project configuration" command to child Maven projects. See #638.
  • enhancement - bind Project configuration is not up-to-date with pom.xml diagnostics to pom.xml. See JLS#797.
  • enhancement - ignore Unknown referenced nature warnings. See JLS#812.
  • bug fix - fixed Force Java Compilation command failing due to Project configuration is not up-to-date with pom.xml errors. See JLS#813.

0.31.0 (September 16th, 2018)

  • enhancement - added Outline support. See #586.
  • enhancement - new java.completion.enabled preference to disable auto-completion. See #631.
  • enhancement - export the utility method requirements.resolveRequirements() as extension API. See #639.
  • enhancement - new code-action: Convert anonymous class to lambda expression. See JLS#658.
  • bug fix - fixed 'Updating Maven projects' showing progress above 100%. See #605.
  • bug fix - give more time to shut down the server properly. See #628.
  • bug fix - fixed BadLocationExceptions thrown during textDocument/documentSymbol invocations. See JLS#794.

0.30.0 (August 31rd, 2018)

  • enhancement - add support for Go to implementation. See #446.
  • enhancement - automatically generate params in Javadoc. See #228.
  • enhancement - publish diagnostic information at the project level. See #608.
  • enhancement - prevent unnecessary build when reopening workspace. See JLS#756.
  • enhancement - update m2e to 1.9.1 See JLS#761.
  • enhancement - lower severity of m2e's Project configuration is not up-to-date... diagnostics. See JLS#763.
  • enhancement - add quickfix for removing unused local var and all assignments. See JLS#769.
  • bug fix - fixed indentation preferences being ignored after completions/refactoring. See 557.
  • bug fix - fixed timestamps in logs. See JLS#742.
  • bug fix - don't send notifications for gradle files modified under the build directory. See JLS#768.
  • bug fix - fixed Tabs being ignored during formatting requests. See JLS#775.

0.29.0 (July 31rd, 2018)

  • enhancement - code action: convert from var to the appropriate type (Java 10+). See JLS#696.
  • enhancement - code action: convert from type to var (Java 10+). See JLS#697.
  • enhancement - Java 9+ versions no longer leak their API by default. See JLS#620.
  • enhancement - add links to completion items' documentation. See JLS#731.
  • bug fix - fix build errors after renaming standalone Java files. See #578.
  • bug fix - fixed extracting to method incorrectly adding the static keyword in nested classes. See JLS#709.

0.28.0 (July 3rd, 2018)

  • enhancement - new java.completion.guessMethodArguments preference to insert best guessed arguments during method completion. See #569.

0.27.0 (June 18th, 2018)

  • enhancement - use more direct OpenJDK download link. See #564.
  • enhancement - code action: access non visible references by changing modifiers or through accessors. See JLS#446.
  • bug fix - fixed formatter file failing to open. See #548.
  • bug fix - fixed class and interface snippets should be proposed according to context. See JLS#681.
  • build - vscode-java-*vsix releases are now archived to http://download.jboss.org/jbosstools/static/jdt.ls/stable/. See #552.

0.26.0 (May 31th, 2018)

  • enhancement - now returns documentation as Markdown during completion. See #318.
  • enhancement - improved class/interface snippets, now adding the package, if necessary. See #505.
  • enhancement - added command to open/create Eclipse formatter settings. See #521.
  • bug fix - fixed Organize imports menu showing in the output panel. See #539.
  • bug fix - fixed missing documentation for methods with parameters, during completion. See JLS#669.

0.25.0 (May 15th, 2018)

  • enhancement - automatically enable Annotation Processing for Maven projects, based on m2e-apt. See #339.
  • enhancement - adds support for on-type formatting. See #530
  • bug fix - improve JAVA_HOME detection on Windows. See #524.

0.24.0 (April 30th, 2018)

  • enhancement - added support for external Eclipse formatter settings. See #2;
  • enhancement - code action: override static method from an instance method. See JLS#444.
  • enhancement - code action: override final methods. See JLS#639.
  • bug fix - fixed flaky diagnostics for TODO markers. See #457.
  • bug fix - fixed Java 10's var's inferred type not shown in enhanced for-loops. See #515.
  • bug fix - fixed random exception thrown during Code Actions resolution. See JLS#642.

0.23.0 (April 16th, 2018)

  • enhancement - added java.completion.overwrite preference. When set to true, code completion overwrites the current text. Else, code is simply added instead. See #462.
  • enhancement - restricted language service on file scheme, for Live Share compatibility. See #492.
  • enhancement - code actions: invalid modifiers. See JLS#445.
  • enhancement - improve build file change detection. See JLS#547.
  • enhancement - do not refresh workspace before build. See JLS#627.
  • bug fix - fixed potential NPE during completion resolution. See JLS#629.

0.22.0 (April 4th, 2018)

  • enhancement - add progress report for background tasks. Controlled with the java.progressReports.enabled preference. See #488.
  • enhancement - add experimental Java 10 support. See #489.
  • enhancement - notification mechanism for 3rd party extensions. See JLS#595.
  • enhancement - Javadoc {@links} should be functional. See JLS#76.
  • enhancement - code action: abstract classes/methods fixes. See JLS#447.
  • enhancement - watch files from all source folders. See JLS#583.
  • bug fix - fixed "Organize Import" command should not be active on non-java files. See #489.
  • bug fix - fixed test imports should not be proposed in main code. See JLS#529.
  • bug fix - fixed broken package Javadoc on Java 9/10. See JLS#612.

0.21.0 (March 15th, 2018)

  • enhancement - process non-java resources. See #400.
  • enhancement - code action: extract variables. See #459.
  • enhancement - [Maven] automatically update module path when required modules changes in module-info.java. See #465.
  • enhancement - should warn about unstable automatic module name in module-info.java. See #467.
  • bug fix - fixed organize import ignoring certain classes. See JLS#552.

0.20.0 (February 28th, 2018)

  • enhancement - incremental (i.e. faster) build triggered on startup, instead of a clean (i.e. slower) build. See #451.
  • enhancement - code action: remove unreachable code. See JLS#437.
  • bug fix - fixed java.import.exclusions preference being ignored during server startup. See #444.
  • bug fix - fixed stub sources being returned even though proper sources were downloaded. See #447.
  • bug fix - fixed attached javadoc being ignored on hover. See JLS#517.
  • bug fix - fixed broken Organize imports in module-info.java. See JLS#549.
  • bug fix - fixed multiline errors. See JLS#567.

0.19.0 (February 15th, 2018)

  • enhancement - added java.projectConfiguration.update command to the explorer menu, for build files. See #159.
  • enhancement - use void as default return value for method templates. See #429.
  • enhancement - new "Indexed for loop" template, triggered by the fori keyword. See #434.
  • enhancement - during import, only trigger "update project configuration" on Maven projects if necessary. See JLS#544.
  • bug fix - removed unnecessary files from the vscode-java distribution, reducing its size from 45MB to 34MB. See #438.
  • bug fix - fixed Organize imports command removing all imports in module-info.java. See #430.
  • bug fix - fixed flaky reporting of test imports in main code. See JLS#528.
  • bug fix - ignore **/META-INF/maven/** paths during import. See JLS#539.

0.18.1 (January 31st, 2018)

  • bug fix - Restore missing "Add unimplemented methods" code action. See #426.

0.18.0 (January 31st, 2018)

  • enhancement - New java.completion.favoriteStaticMembers preference to define static members to be automatically imported. See #368.
  • enhancement - Store method parameters in compiled classes, for Maven projects configured with the -parameters compiler parameter. See #391.
  • enhancement - New java.saveActions.organizeImports preference to enable Organize imports as a save action. See #402.
  • enhancement - New java.autobuild.enabled preference to enable/disable the 'auto build'. See #406.
  • enhancement - New java.completion.importOrder preference to customize imports order. See #420.
  • bug fix - fixed hover/navigation for types in module-info.java. See JLS#397.
  • bug fix - fixed proper test classpath isolation. Test classes are no longer available to main code for Maven and pure Eclipse projects. See JLS#526.
  • bug fix - fixed autocompletion/hover performance for Java 9 projects. See #398.

0.17.0 (January 16th, 2018)

  • enhancement - code-action: add missing serialVersionUID field. See #401.
  • enhancement - add new template to create a new Object. See #407.
  • bug fix - fixed autocompletion issues caused by changing the JDK used to run the server. See #392.
  • bug fix - fixed encoding issues when saving UTF-8 files containing Chinese characters. See #394.
  • bug fix - fixed server startup status never ending after an error. See #403.

0.16.0 (December 15th, 2017)

  • enhancement - add preferences to disable Maven (java.import.maven.enabled) and Gradle (java.import.gradle.enabled) imports (import as Eclipse instead). See #388.
  • enhancement - remove redundant diagnostics reports. See JLS#468.
  • enhancement - code action: handle unreachable catch blocks. See JLS#381.
  • bug fix - fixed java.import.exclusions preference should be a real array. See #371.
  • bug fix - fixed renaming/creating java files requiring a restart. See #380.
  • bug fix - fixed -DGRADLE_HOME parameter in java.jdt.ls.vmargs being ignored by jdt.ls. See #383.
  • task - removed region folding support as it's now provided by VS Code directly. See #369.

0.15.0 (November 30th, 2017)

  • enhancement - add Java 9 support for Gradle projects. See #321.
  • enhancement - add option to choose between full and incremental compilation. See #364.
  • enhancement - improve code completion/diagnostic reports performance. See #381.
  • enhancement - log errors when compiling standalone java files. See #462.
  • enhancement - code action: remove unused code. See JLS#448.
  • enhancement - code action: change return type of a method. See JLS#435.
  • enhancement - significantly faster startup for existing workspaces with Gradle projects. SeeJLS#451.
  • enhancement - delay symbols queries until server is ready. See JLS#452.
  • bug fix - fixed duplicate imports on "Organize imports" action. See #253.
  • bug fix - fixed autocompletion overwriting the following characters. See #352.
  • bug fix - do not report errors for Java files outside their project's classpath. See #456.
  • bug fix - fixed high CPU usage on Windows. See JLS#378.
  • bug fix - return SymbolKind.Method instead of SymbolKind.Function for methods. See JLS#422.
  • bug fix - fixed java extensions started twice. See JLS#450.
  • bug fix - fixed NPEs occurring during code action computation. See JLS#453 and JLS#470 .

0.14.0 (November 9th, 2017)

  • enhancement - add CodeLens support from .class files. See #343.
  • enhancement - new multi-root support. See #347.
  • bug fix - fixed starting jdt.ls with JDK 10-ea. See #356.
  • bug fix - fixed 'java.workspace.compile' command to be invoked by the debugger. See #357.

0.13.0 (November 2nd, 2017)

  • enhancement - new Force Java compilation command (Shift+Alt+b). See #277.
  • enhancement - significantly faster startup for existing workspaces with Maven projects. See #336.
  • enhancement - new Organize Imports command (Shift+Alt+o). See #341.
  • bug fix - fixed highlight support in module-info.java. See #256.
  • bug fix - fixed inner pom.xml changes causing infinite update project loop. See #331.
  • bug fix - fixed keybinding for "Update project configuration" command conflicting with AltGr+u (now Shift+Alt+u). See #348.
  • bug fix - fixed autocompletion overwritting following characters. See #352.
  • bug fix - fixed hover not working when browsing *.class files. See JLS#390.
  • bug fix - fixed Java Model Exception when changing class name. See JLS#400.

0.12.0 (October 17th, 2017)

  • enhancement - experimental Java 9 support (for Maven and Eclipse projects). See JLS#185.
  • enhancement - add Extract to method refactoring. See #303.
  • enhancement - add region folding support. See #316.
  • enhancement - improved Java snippets with transformations. See #317.
  • enhancement - made Java language server output less intrusive. See #326.
  • enhancement - add 3rd party decompiler support. See #334.
  • bug fix - fixed inconsistent package error on standalone java files. See #274.
  • bug fix - fixed Javadoc not shown on hover, after saving a file. See JLS#375.
  • bug fix - fixed conflicts caused by 3rd party extensions updates. See JLS#385;

0.11.0 (October 2nd, 2017)

  • enhancement - external debugger now supported. See #9.
  • enhancement - code-action: handle exceptions with try/catch block or throws statement. See #300.
  • bug fix - fixed failing autocompletion when class name contains $. See #301.
  • bug fix - fixed OperationCanceledException on hover. See #302.
  • bug fix - fixed Index Out Of Bounds Exceptions during completion. See #306.
  • bug fix - fixed NPE in completion for package-less standalone classes. See #312.

0.10.0 (September 15th, 2017)

  • enhancement - enable 3rd party VS Code extensions to extend the JDT Language Server. See #282.
  • enhancement - add new java.execute.workspaceCommand command, for 3rd party VS Code extensions. See #292.
  • enhancement - References CodeLens disabled by default. See #293.
  • enhancement - add Types to symbols outline, to work with the Code Outline extension. See #294.
  • bug fix - fixed content assist for Anonymous class creation. See JLS#57.
  • bug fix - fixed incorrect hover for unresolved types. See JLS#333.

0.9.0 (August 31st, 2017)

  • enhancement - rename symbols support (Doesn't rename files at the moment). See #71.
  • enhancement - use system's Gradle runtime when no wrapper found. See #232.
  • enhancement - code action: generate getters and setters. See #263.
  • enhancement - code action: add unimplemented methods. See #270.
  • bug fix - support 32-bit platforms. See #201.
  • bug fix - fixed implementor codelens showing <<MISSING COMMAND>> when typing. See #266.
  • bug fix - fixed <<MISSING COMMAND>> when invoking code actions. See #288.
  • bug fix - fixed Index out of bounds exceptions during code lens resolution, after document changes. See JLS#340.

0.8.0 (July 31st, 2017)

  • enhancement - generate getters and setters from autocompletion. See #100.
  • enhancement - enable/disable default Java formatter with the java.format.enabled preference. See #186.
  • enhancement - exclude folders from Java project detection via glob patterns with the java.import.exclusions preference. See #229.
  • enhancement - enable/disable signature help with the java.signatureHelp.enabled preference. See #252.
  • enhancement - enable/disable the implementations code lens with the java.implementationsCodeLens.enabled preference. See #257.
  • bug fix - gracefully handle deleted required eclipse settings files. See #132.
  • bug fix - properly render documentation during code completion. See #215.
  • bug fix - fixed opening network folders on Windows. See #259.
  • bug fix - diagnostics mismatch after applying code actions. See JLS#279.
  • bug fix - fixed Maven support running on JDK 9 and IBM JDK. See JLS#315.
  • bug fix - keep logs clean from OperationCanceledException during code assist. See JLS#317.

0.7.0 (July 4th, 2017)

  • enhancement - enabled @formatter:on/off tags in source. See #236.
  • enhancement - improved error reporting in standalone java files. See #242.
  • enhancement - hover should show element signature. See JLS#259.
  • enhancement - code-action: add missing methods. See JLS#177.
  • enhancement - code-action: missing variables, fields, params. See JLS#178.
  • enhancement - code-action: organize imports. See JLS#164.
  • enhancement - code-action: rename type. See JLS#264.
  • enhancement - code-action: fix package declaration. See JLS#265.
  • enhancement - code-action: remove unnecessary Javadoc param. See JLS#274.
  • enhancement - code-action: add missing Javadoc params. See JLS#275.
  • enhancement - code-action: add missing Javadoc params. See JLS#275.
  • enhancement - code-action: fix type mismatch. See JLS#276.
  • enhancement - code-action: fix missing attribute in annotation. See JLS#277.
  • bug fix - fixed wrong URI set for diagnostics of standalone java files. See JLS#268.
  • bug fix - fixed Error computing hover: **/package-summary.html not found in JavaDoc jar. See #248.
  • bug fix - fixed Invalid project description thrown when reopening Eclipse projects. See #244.

0.6.0 (June 15th, 2017)

  • enhancement - reduced extension size by ~25%. See JLS#252.
  • bug fix - fixed OperationCanceledException during completion. See JLS#240.
  • bug fix - fixed changes in Eclipse settings file are ignored. See #239.
  • bug fix - package autocompletion should return only 1 package. See #234.
  • bug fix - autocompletion on overridden methods should create the method body. See #85.

0.5.0 (May 31st, 2017)

  • enhancement - enable support for CamelCase type search. See JLS#219.
  • enhancement - server startup now uses progress UI. See #225.
  • bug fix - fixed autocomplete inserting classname+package text instead of classname. See #175.
  • bug fix - fixed Timed out while retrieving the attached javadoc. error. See #176.
  • bug fix - fixed autocompletion not cancelled on space. See #187.
  • bug fix - fixed Gradle import failing behind corporate proxy with authentication. See #211.
  • bug fix - fixed Unable to locate secure storage module error. See #212.
  • bug fix - fixed CancellationException in output log. See #213.
  • bug fix - fixed Illegal argument, contents must be defined error on hover. See #214.
  • bug fix - fixed code snippet appearing before completion results. See #216.
  • bug fix - fixed code snippet using deprecated syntax. See #217.
  • bug fix - fixed navigation from disassembled source code. See #222.
  • bug fix - fixed Javadoc missing from inherited methods. See #226.
  • bug fix - fixed Problems encountered while copying resources. Resource '/jdt.ls-java-project/src/pom.xml' does not exist error. See #244.

0.4.0 (May 15th, 2017)

  • enhancement - new Open Java Language Server log file command. See #209.
  • enhancement - expand workspace symbol search to all classes from classpath. See #204.
  • bug fix - fixed outline for classes from classpath. See #206.
  • bug fix - fixed ambiguous results from class outline. See JLS#214.

0.3.0 (May 4th, 2017)

  • enhancement - reduce confusion about "Classpath is incomplete" warning by providing a link to the wiki page. See #193.
  • enhancement - enable String deduplication on G1 Garbage collector by default, to improve memory footprint. See #195.

0.2.1 (April 24th, 2017)

  • bug fix - fix excessive 'Unable to get documentation under 500ms' logging. See #189.

0.2.0 (April 19th, 2017)

  • enhancement - extension now embeds the Java Language Server. See #178.
  • bug fix - fixed Java Language Server status update on startup. See #179.
  • bug fix - fixed detection of nested Gradle projects. See #165.

0.1.0 (March 30th, 2017)

  • enhancement - support starting the Java Language Server with JDK 9. See #43.
  • enhancement - add support for build-helper-maven-plugin. See JLS#198.
  • enhancement - add support for Maven compilerIds jdt, eclipse, javac-with-errorprone. See JLS#196.
  • enhancement - log Server's stderr/sdout in VS Code's console, to help troubleshooting. See #172.
  • bug fix - [tentative] prevent workspace corruption on shutdown. See JLS#199.
  • bug fix - opening standalone Java files fails to initialize the server. See JLS#194.
  • bug fix - intellisense fails on package-less classes. See #166.

0.0.13 (March 17th, 2017)

  • bug fix - java projects are no longer imported. See #167.

0.0.12 (March 16th, 2017)

  • enhancement - new java.configuration.maven.userSettings preference to set Maven's user settings.xml. See JLS#184.
  • enhancement - adopt new VS Code SnippetString API. See #99.
  • bug fix - saving a file doesn't update compilation errors on dependent classes. See JLS#187.

0.0.11 (March 2nd, 2017)

  • build - now uses Eclipse ™ JDT Language Server under the hood. See #152.
  • enhancement - maven errors are reported. See JLS#85.
  • enhancement - code Actions for adding missing quote, removing unused import and superfluous semicolon. See JLS#15.
  • bug fix - correct Javadoc highlighting. See #94

0.0.10 (February 08th, 2017)

  • enhancement - improve intellisense performance. See #121.
  • enhancement - document server tracing capabilities. See #145.
  • enhancement - disable reference code lenses with java.referencesCodeLens.enabled. See #148.
  • bug fix - fix dubious intellisense relevance. See #142.
  • bug fix - fix broken autocompletion on constructors. See #143.
  • bug fix - fix brackets/parentheses autoclosing. See #144.

0.0.9 (January 16th, 2017)

  • enhancement - autoclose Javadoc statements, adding * on new lines. See #139.
  • bug fix - fix Error when Go to definition performed on non-code portion. See #124.
  • bug fix - fix saving java.errors.incompleteClasspath.severity preference. See #128.
  • bug fix - fix NPE occurring when clicking on comment section of a Java file. See #131.
  • bug fix - fix JAVA_HOME detection on MacOS. See #134.
  • bug fix - fix support for quoted VM arguments. See #135.
  • bug fix - don't display Code Lenses from Lombok-generated code. See #137.
  • bug fix - remove langserver.log file generation under home directory. See #140.

0.0.8 (December 22nd, 2016)

  • enhancement - add basic Java Gradle support (Android not supported). See #10.
  • enhancement - disable warning about Incomplete Classpath. See #107.
  • enhancement - new Update project configuration command (Ctrl+Alt+U or Cmd+Alt+U on MacOS). See #113.
  • enhancement - automatically update java classpath/configuration on build file change. See #122.
  • bug fix - fix completion on import statements. See #68.
  • bug fix - fix errors when modifying eclipse configuration files. See #105.
  • bug fix - fix errors when restoring deleted files from git. See #109.
  • bug fix - invalid locations for Workspace-wide errors. See JLS#107.

0.0.7 (November 23rd, 2016)

  • enhancement - basic Java support for standalone Java files. See #27.
  • enhancement - start Java Language Server when pom.xml is detected. See #84.
  • bug fix - fix out of synch error markers. See #87
  • bug fix - fix missing generic types in autocompletion. See #69.
  • bug fix - fix ignored jdt.ls.vmargs. See #88.

0.0.6 (November 1st, 2016)

  • enhancement - auto-import packages referenced by code complete. See #50.
  • enhancement – report Java errors for all files project in the project. See 58.
  • enhancement – display package names on code completion proposals for Types [#47] (eclipse-jdtls/eclipse.jdt.ls#47).
  • enhancement - add support for the JDK_HOME environment variable in VS Code settings. See #65.
  • enhancement - add Java code snippets. See #83.
  • bug fix - fix errors thrown when opening a standalone file. See #55, #67.
  • bug fix - fix JAVA_HOME detection mechanism. See #74.

0.0.5 (October 13th, 2016)

  • enhancement - configure extra VM arguments in VS Code settings, used to launch the Java Language Server. See #25.
  • enhancement - configure java.home property in VS Code settings. See #28.
  • enhancement - improve Javadoc formatting on hover (scrollbar). See #31.
  • enhancement - add feedback when starting the Java Language Server. See #49.
  • enhancement - add hover for package fragments. See JLS#84.
  • enhancement - better relevance for code completion. See JLS#77.
  • bug fix - fix Java Language Server downloading when using a Proxy (take 2). See #42.
  • bug fix - fix race condition on Java Language Server start. See JLS#81.

0.0.4 (September 26th, 2016)

  • enhancement - improved Javadoc/Markdown formatting. See #13.
  • enhancement - provide Java Language Server download feedback. See #20.
  • enhancement - provide syntax highlighting for opened .class files. See #21.
  • enhancement - provide link to Oracle JDK downloads on MacOS. See #37.
  • enhancement - provide better information on JDK/JAVA_HOME requirements. See #32.
  • bug fix - prevent java.lang.NullPointerException in DocumentLifeCycleHandler. See #34.
  • bug fix - fix Java Language Server downloading when using a Proxy. See #35.
  • bug fix - fix Java Language Server headers format. See JLS#74.
  • bug fix - fix project import reporting progress > 100%. See JLS#67.

0.0.3 (September 16th, 2016)

  • enhancement - in addition to maven, we now support basic Eclipse projects. See JLS#37.
  • enhancement - go to Definition (F12) is enabled for libraries and can display Java code that is not part of project's source code
  • enhancement - code complete triggers are added for .#@ characters. See #19.
  • bug fix - opening a Maven project a 2nd time doesn't work. See JLS#66.

0.0.2 (September 14th, 2016)

  • enhancement - download the Java Language Server through HTTPS.

0.0.1 (September 12, 2016)

  • Maven pom.xml project support
  • Basic Eclipse Java project support
  • As you type reporting of parsing and compilation errors
  • Code completion
  • Javadoc hovers
  • Code outline
  • Code navigation
  • Code lens (references)
  • Highlights
  • Code formatting