`no-node-access` false-positive warning on object property with `select` name

[AlexKrupko]

Have you read the Troubleshooting section?

Yes

Plugin version

v7.5.3

ESLint version

v9.29.0

Node.js version

v23.7.0

Bug description

After upgrading to version 7.5.3, the no-node-access warning appears on object property with select name

Steps to reproduce

const ui = {
    select: selector.byRole('combobox', {name: 'Test label'}),
};

test('...', () => {
    // ......
    const select = ui.select.get();
    expect(select).toBeVisible();
    expect(select).toHaveClass(selectClasses.select);
});

Both ui.select.get() and selectClasses.select are warned.

Error output/screenshots

No response

ESLint configuration

--

Rule(s) affected

no-node-access

Anything else?

No response

Do you want to submit a pull request to fix this bug?

No

[goodallt]

I am also experiencing this issue with a custom function we have implemented with the name .select

[ravicious]

In a similar fashion, it reports every callsite that uses react-select-event. Already reported in #1024 (comment) but I wanted to highlight it here as well.

await selectEvent.select(screen.getByLabelText('Version'), 'v6');

https://github.com/gravitational/teleport/blob/f3d51b360925c99f6332ff08415d44e058ebd881/web/packages/teleport/src/Roles/RoleEditor/StandardEditor/MetadataSection.test.tsx#L91

[Belco90]

This will be fixed by #1033

[github-actions]

🎉 This issue has been resolved in version 7.5.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[anomiex]

While the specific example given above seems fixed, I'm still seeing a lot of false positives in my code. Trimmed down to a minimal-ish example, that code could look something like this:

import { render, screen } from '@testing-library/react';
import { createRegistry } from '@wordpress/data';

test('...', () => {
    const registry = createRegistry();
    expect( registry.select( 'store' ) ).not.toBeUndefined();
});

Or even

import { render, screen } from '@testing-library/react';

function createRegistry() {
    return {
        select: store => "ok",
    };
}

test('...', () => {
    const registry = createRegistry();
    expect( registry.select( 'store' ) ).not.toBeUndefined();
});

[joshkel]

We're also seeing false positives with 7.5.4. In our case, it's from Knex database calls in our tests:

    const result = await db.select().table('DataRecord');

(We could probably try and change our setup to strictly separate tests that reference the DOM from tests that reference the database then change our ESLint rules to only run eslint-plugin-testing-library on DOM tests, but that's an invasive change.)