fix(no-wait-for-side-effects): detect await expressions#1008
Conversation
87f42ea to
bb3ced4
Compare
no-wait-for-side-effects doesn't detect await expressionno-wait-for-side-effects doesn't detect await expressions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
+ Coverage 96.27% 96.29% +0.01%
==========================================
Files 46 47 +1
Lines 2472 2483 +11
Branches 1025 1027 +2
==========================================
+ Hits 2380 2391 +11
Misses 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Belco90
left a comment
There was a problem hiding this comment.
Thanks for addressing this bug!
I see code coverage went down, so Codecov complains. Can you add extra tests for no-wait-for-multiple-assertions? It's indirectly affected (see more details).
no-wait-for-side-effects doesn't detect await expressions…property-identifier-node-await-expression
…property-identifier-node-await-expression
there was a redundant On a side note - the CI is so fast, I like it! 🚀 |
I'm glad you like the CI speed! We can do even better, hopefully we can switch to vitest soon. |
|
🎉 This PR is included in version 7.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #742