refactor: strengthen type safety#1015
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
=======================================
Coverage 96.27% 96.28%
=======================================
Files 46 47 +1
Lines 2472 2531 +59
Branches 1025 1047 +22
=======================================
+ Hits 2380 2437 +57
- Misses 92 94 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Belco90
added
the
chore
Belco90
reviewed
Jun 2, 2025
Member
Belco90
left a comment
Belco90
left a comment
There was a problem hiding this comment.
Thanks for taking care of this! Just added some comments.
Belco90
approved these changes
Jun 4, 2025
Belco90
changed the title
|
🎉 This PR is included in version 7.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a minor change, but I refactored a few parts that caught my attention. Please feel free to close this PR if it doesn't meet your expectations. I appreciate your review!
Checks
Changes
update test case types to use rule-tester types.
→ Due to deprecation of TSESLint's
InvalidTestCaseandValidTestCase.apply
as constfor stricter type safety on query definitions.add explicit return type to
createTestingLibraryRulefor better type safety.→ Because a type error occurred in test files when passing the rule as the second argument to
ruleTester.run.Context