fix(no-node-access): stop reporting focus() usage#1028
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
=======================================
Coverage 96.30% 96.30%
=======================================
Files 47 47
Lines 2542 2543 +1
Branches 1046 1051 +5
=======================================
+ Hits 2448 2449 +1
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Belco90
requested changes
Jun 11, 2025
Belco90
left a comment
Member
There was a problem hiding this comment.
Can you add these two things to the rule's doc?
- A GitHub Alert indicating why
focus()is not reported - A link in the
Further readingsection at the bottom pointing to https://testing-library.com/docs/guide-events/
focus() usage
Member
Author
|
I added in c6c5cdb!📕 |
Belco90
approved these changes
Jun 11, 2025
|
🎉 This PR is included in version 7.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks
Changes
EVENT_HANDLER_METHODSfor consistencyContext
Fixes #1027