Fix no-node-access false positives for object literal properties#1319
Open
sjh9714 wants to merge 1 commit into
Open
Fix no-node-access false positives for object literal properties#1319sjh9714 wants to merge 1 commit into
sjh9714 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes false positives in
no-node-accesswhen accessing data properties such aschildrenoractiveElementon plain object literals.What changed
Why
Issue #683 reports that
no-node-accesscan report regular data objects if their property names overlap with DOM node-returning properties. These object properties are not direct DOM node access and should not be reported.Testing
pnpm test tests/rules/no-node-access.test.tspnpm run lintpnpm run type-checkpnpm testFixes #683