Fix consistent-data-testid fileName on Windows paths#1320
Open
sjh9714 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
{fileName}replacement inconsistent-data-testidwhen ESLint reports Windows-style paths.What changed
filenametest case.indexfile and dynamic route filename behavior.Why
Issue #782 reports that
{fileName}can expand to the full Windows path instead of just the component file name because the rule only splits paths on/.Testing
pnpm test tests/rules/consistent-data-testid.test.tspnpm run lintpnpm run type-checkpnpm testgit diff upstream/main...HEAD --checkFixes #782