Skip to content

docs: fix example in prefer-screen-queries.md#995

Merged
Belco90 merged 2 commits into
testing-library:mainfrom
danielrentz:patch-1
Apr 30, 2025
Merged

docs: fix example in prefer-screen-queries.md#995
Belco90 merged 2 commits into
testing-library:mainfrom
danielrentz:patch-1

Conversation

@danielrentz
Copy link
Copy Markdown
Contributor

Checks

Changes

  • Add missing import of "within" in example code of prefer-screen-queries.

Context

Add missing import of "within" in example code.

Signed-off-by: Daniel Rentz <danielrentz@users.noreply.github.com>
@Belco90
Copy link
Copy Markdown
Member

Belco90 commented Apr 30, 2025

Hi @danielrentz, thanks for your contribution. Can you update your branch with main, please?

@danielrentz
Copy link
Copy Markdown
Contributor Author

@Belco90 done

@Belco90 Belco90 enabled auto-merge April 30, 2025 07:11
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (26d360e) to head (d2688da).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #995   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files          46       46           
  Lines        2472     2472           
  Branches     1025     1030    +5     
=======================================
  Hits         2380     2380           
  Misses         92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Belco90 Belco90 added this pull request to the merge queue Apr 30, 2025
Merged via the queue into testing-library:main with commit be6801f Apr 30, 2025
31 checks passed
@Belco90
Copy link
Copy Markdown
Member

Belco90 commented Apr 30, 2025

@all-contributors please add @danielrentz for docs

@allcontributors
Copy link
Copy Markdown
Contributor

@Belco90

I've put up a pull request to add @danielrentz! 🎉

@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants