Fix benchmark CI workflow and format code

- Remove redundant Python transformation script (Rust already generates GitHub format)
- Fix JSON parsing in benchmark summary display
- Improve file copying in workflow
- Run cargo fmt on all code

Author: testingapisname

.github/workflows/benchmark.yml

@@ -4,7 +4,8 @@ on:
   push:
     branches: [ main ]
     paths:
-      - 'crates/rust-hsm-cli/src/pkcs11/benchmark.rs'
+      - 'crates/rust-hsm-cli/src/**'
+      - 'crates/rust-hsm-core/src/**'
       - '.github/workflows/benchmark.yml'
   schedule:
     # Run weekly on Sunday at 2am UTC
@@ -17,6 +18,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0  # Fetch full history for gh-pages branch creation
 
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
@@ -27,61 +30,126 @@ jobs:
       - name: Start container
         run: docker compose up -d
 
-      - name: Wait for container
-        run: sleep 5
+      - name: Wait for container to be ready
+        run: sleep 10
 
-      - name: Initialize test token
+      - name: Initialize test token using rust-hsm-cli
         run: |
-          docker exec rust-hsm-app softhsm2-util --init-token \
-            --slot 0 --label BENCH_TOKEN \
-            --so-pin 12345678 --pin 123456
+          docker exec rust-hsm-app rust-hsm-cli init-token \
+            --label BENCH_TOKEN --so-pin 12345678
+          docker exec rust-hsm-app rust-hsm-cli init-pin \
+            --label BENCH_TOKEN --so-pin 12345678 --user-pin 123456
       
-      - name: Run benchmark
+      - name: Run benchmark with rust-hsm-cli
         run: |
           docker exec rust-hsm-app rust-hsm-cli benchmark \
             --label BENCH_TOKEN --user-pin 123456 \
-            --iterations 1000 --warmup 50 \
-            --format json --output /app/benchmark-results.json
+            --iterations 50 --warmup 5 \
+            --format json --output /app/benchmark-results.json \
+            --data-sizes
       
-      - name: Copy results
+      - name: Copy benchmark results
         run: |
+          # Copy the main results file
           docker cp rust-hsm-app:/app/benchmark-results.json ./benchmark-results.json
+          
+          # Copy GitHub Actions format file (automatically generated by rust-hsm-cli)
           docker cp rust-hsm-app:/app/benchmark-results-gh.json ./benchmark-results-gh.json
+          
+          # Verify files exist and show samples
+          echo "=== Main benchmark results ==="
+          head -20 benchmark-results.json
+          
+          echo "=== GitHub Actions format ==="
+          head -20 benchmark-results-gh.json
+      
+      - name: Setup gh-pages branch if needed
+        run: |
+          git config --global user.name 'github-action-benchmark'
+          git config --global user.email 'github@users.noreply.github.com'
+          
+          # Check if gh-pages exists remotely
+          if ! git ls-remote --exit-code --heads origin gh-pages > /dev/null 2>&1; then
+            echo "Creating gh-pages branch..."
+            git checkout --orphan gh-pages
+            git rm -rf .
+            echo "# HSM Performance Benchmarks" > README.md
+            echo "" >> README.md
+            echo "Automated benchmark results for rust-hsm PKCS#11 operations." >> README.md
+            echo "" >> README.md
+            echo "Generated by [github-action-benchmark](https://github.com/benchmark-action/github-action-benchmark)." >> README.md
+            git add README.md
+            git commit -m "Initialize gh-pages branch for benchmarks"
+            git push origin gh-pages
+            git checkout main
+            echo "✓ Created gh-pages branch"
+          else
+            echo "✓ gh-pages branch already exists"
+          fi
       
       - name: Store benchmark result
         uses: benchmark-action/github-action-benchmark@v1
         with:
-          tool: 'customBiggerIsBetter'
+          name: 'HSM Performance Benchmarks'
+          tool: 'customBiggerIsBetter'  # ops/sec - higher is better
           output-file-path: benchmark-results-gh.json
           github-token: ${{ secrets.GITHUB_TOKEN }}
           auto-push: true
           # Show alert with commit comment on detecting possible performance regression
-          alert-threshold: '110%'
+          alert-threshold: '150%'  # Alert if performance degrades by 50%
           comment-on-alert: true
           fail-on-alert: false
           alert-comment-cc-users: '@testingapisname'
 
-      - name: Upload benchmark results
+      - name: Upload benchmark results as artifacts
         uses: actions/upload-artifact@v4
         with:
           name: benchmark-results
-          path: benchmark-results.json
+          path: |
+            benchmark-results.json
+            benchmark-results-gh.json
+      
+      - name: Display benchmark summary
+        run: |
+          echo "=== Benchmark Summary ==="
+          if [ -f benchmark-results.json ]; then
+            jq -r '.results[]? | "\(.result.name): \(.ops_per_sec | round) ops/sec"' benchmark-results.json || echo "Could not parse results"
+          else
+            echo "No benchmark results file found"
+          fi
       
       - name: Comment PR with results
         if: github.event_name == 'pull_request'
         uses: actions/github-script@v7
         with:
           script: |
             const fs = require('fs');
+            
+            if (!fs.existsSync('benchmark-results.json')) {
+              console.log('No benchmark results file found');
+              return;
+            }
+            
             const results = JSON.parse(fs.readFileSync('benchmark-results.json', 'utf8'));
             
             let comment = '## 📊 Benchmark Results\n\n';
-            comment += '| Operation | Ops/sec | Avg (ms) | P95 (ms) |\n';
-            comment += '|-----------|---------|----------|----------|\n';
+            comment += '| Operation | Ops/sec | Avg (ms) | P95 (ms) | P99 (ms) |\n';
+            comment += '|-----------|---------|----------|----------|----------|\n';
             
-            results.results.forEach(r => {
-              comment += `| ${r.name} | ${r.ops_per_sec.toFixed(1)} | ${r.avg_latency_ms.toFixed(2)} | ${r.p95_ms.toFixed(2)} |\n`;
-            });
+            if (results.results) {
+              results.results.forEach(r => {
+                const name = r.result?.name || 'Unknown';
+                const ops = (r.ops_per_sec || 0).toFixed(1);
+                const avg = (r.avg_latency_ms || 0).toFixed(2);
+                const p95 = (r.p95_ms || 0).toFixed(2);
+                const p99 = (r.p99_ms || 0).toFixed(2);
+                comment += `| ${name} | ${ops} | ${avg} | ${p95} | ${p99} |\n`;
+              });
+            } else {
+              comment += '| No results available | - | - | - | - |\n';
+            }
+            
+            comment += '\n📈 [View historical results](https://testingapisname.github.io/rust-hsm/dev/bench/)\n';
             
             github.rest.issues.createComment({
               issue_number: context.issue.number,
@@ -92,4 +160,6 @@ jobs:
       
       - name: Stop container
         if: always()
-        run: docker compose down
+        run: |
+          docker compose down
+          docker volume prune -f

crates/rust-hsm-core/src/pkcs11/benchmark.rs

@@ -1146,7 +1146,7 @@ fn output_json(
         let mut file = File::create(path)?;
         file.write_all(json.as_bytes())?;
         eprintln!("✓ Benchmark results written to {}", path);
-        
+
         // Also generate GitHub Actions format (array of name/value/unit)
         if path.ends_with(".json") {
             let gh_path = path.replace(".json", "-gh.json");
@@ -1168,7 +1168,7 @@ fn output_github_format(results: &[BenchmarkResult], path: &str) -> Result<()> {
         value: f64,
         unit: String,
     }
-    
+
     let gh_results: Vec<GitHubBenchmark> = results
         .iter()
         .map(|r| GitHubBenchmark {
@@ -1177,11 +1177,11 @@ fn output_github_format(results: &[BenchmarkResult], path: &str) -> Result<()> {
             unit: "ops/sec".to_string(),
         })
         .collect();
-    
+
     let json = serde_json::to_string_pretty(&gh_results)?;
     let mut file = File::create(path)?;
     file.write_all(json.as_bytes())?;
-    
+
     Ok(())
 }