Skip to content

Commit dddcdcf

Browse files
use node 24
1 parent 4c12875 commit dddcdcf

8 files changed

Lines changed: 30 additions & 175 deletions

File tree

.github/workflows/main.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
fail-fast: false
1616
matrix:
17-
node-version: [20, 22]
17+
node-version: [20, 22, 24]
1818
steps:
1919
- uses: actions/checkout@v4
2020
- uses: actions/setup-node@v4
@@ -26,7 +26,8 @@ jobs:
2626
- run: npm run lint
2727
- run: npm test
2828
- name: Verify dist/ is up to date
29-
if: matrix.node-version == 20
29+
# Action runtime is Node 24 (per action.yml). Bundle on that.
30+
if: matrix.node-version == 24
3031
run: |
3132
npm run build
3233
git diff --exit-code dist/ || (
@@ -43,7 +44,7 @@ jobs:
4344
- uses: actions/checkout@v4
4445
- uses: actions/setup-node@v4
4546
with:
46-
node-version: 20
47+
node-version: 24
4748
cache: 'npm'
4849
- uses: ./
4950
with:

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
node_modules
22

3+
# Compiled test output
4+
test-build/
5+
36
# OS / editor
47
.DS_Store
58

.mocharc.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,2 @@
1-
require:
2-
- ts-node/register
3-
spec: 'test/**/*.test.ts'
1+
spec: 'test-build/test/**/*.test.js'
42
timeout: 10000

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20
1+
24

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,6 @@ outputs:
9393
log-file:
9494
description: Absolute path to the tunnel log file on the runner
9595
runs:
96-
using: 'node20'
96+
using: 'node24'
9797
main: 'dist/main/index.js'
9898
post: 'dist/post/index.js'

package-lock.json

Lines changed: 0 additions & 165 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,18 @@
1515
"format-check": "prettier --check '**/*.ts'",
1616
"lint": "eslint 'src/**/*.ts'",
1717
"build": "ncc build src/index.ts -o dist/main && ncc build src/post.ts -o dist/post",
18+
"pretest": "npm run build:test",
1819
"test": "mocha --grep @slow --invert",
20+
"pretest:slow": "npm run build:test",
1921
"test:slow": "mocha --grep @slow --timeout 75000",
22+
"build:test": "tsc -p tsconfig.test.json && cp src/options.json test-build/src/options.json",
2023
"test:e2e": "http-server ./test -p 8080 > /dev/null 2>&1 & node ./test/e2e.test.js",
2124
"all": "npm run build && npm run format && npm run lint && npm run test"
2225
},
2326
"author": "Jochen Delabie <jochen@testingbot.com>",
2427
"license": "MIT",
2528
"engines": {
26-
"node": ">=20"
29+
"node": ">=24"
2730
},
2831
"keywords": [
2932
"testingbot",
@@ -45,7 +48,6 @@
4548
"mocha": "^11.7.5",
4649
"prettier": "^3.8.3",
4750
"sinon": "^21.0.3",
48-
"ts-node": "^10.9.2",
4951
"typescript": "^6.0.2",
5052
"webdriverio": "^9.27.0"
5153
},

tsconfig.test.json

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
{
2+
"compilerOptions": {
3+
"target": "ES2022",
4+
"module": "commonjs",
5+
"outDir": "./test-build",
6+
"rootDir": ".",
7+
"strict": true,
8+
"esModuleInterop": true,
9+
"resolveJsonModule": true,
10+
"moduleResolution": "node10",
11+
"ignoreDeprecations": "6.0",
12+
"sourceMap": true
13+
},
14+
"include": ["src/**/*.ts", "test/**/*.ts"],
15+
"exclude": ["node_modules"]
16+
}

0 commit comments

Comments
 (0)