Drop trait FromStr

Author: kyleect

README.md

@@ -1,8 +1,6 @@
 # http_message
 
 ```rust
-use std::str::FromStr;
-
 use http_message::PartialHttpRequest;
 
 fn main() {
@@ -19,6 +17,19 @@ fn main() {
 
     assert_eq!(Some(&(24..34)), partial.header_span("x-key"));
     assert_eq!(Some("x-key: 123"), partial.header_str("x-key"));
+
+    let request: HttpRequest = partial.into();
+
+    assert_eq!(
+        HttpRequest {
+            uri: Uri::new("https://example.com"),
+            method: "GET".into(),
+            http_version: "HTTP/1.1".into(),
+            headers: vec![("x-key", "123").into()],
+            body: None
+        },
+        request
+    );
 }
 ```
 

examples/main.rs

@@ -1,6 +1,7 @@
-use std::str::FromStr;
-
-use http_message::PartialHttpRequest;
+use http_message::{
+    PartialHttpRequest,
+    models::{request::HttpRequest, uri::Uri},
+};
 
 fn main() {
     let partial = PartialHttpRequest::from_str("GET https://example.com\nx-key: 123").unwrap();
@@ -16,4 +17,17 @@ fn main() {
 
     assert_eq!(Some(&(24..34)), partial.header_span("x-key"));
     assert_eq!(Some("x-key: 123"), partial.header_str("x-key"));
+
+    let request: HttpRequest = partial.into();
+
+    assert_eq!(
+        HttpRequest {
+            uri: Uri::new("https://example.com"),
+            method: "GET".into(),
+            http_version: "HTTP/1.1".into(),
+            headers: vec![("x-key", "123").into()],
+            body: None
+        },
+        request
+    );
 }

src/main.rs

@@ -1,5 +1,3 @@
-use std::str::FromStr;
-
 fn main() {
     use std::env;
     use std::fs;

src/models/partial_request.rs

@@ -1,5 +1,5 @@
 use core::fmt;
-use std::{ops::Range, str::FromStr};
+use std::ops::Range;
 
 use crate::{
     error::Error,
@@ -26,6 +26,10 @@ impl fmt::Display for PartialHttpRequest {
 }
 
 impl PartialHttpRequest {
+    pub fn from_str(message: &str) -> Result<Self, Error> {
+        parse_request(message, parse_first_line)
+    }
+
     pub fn parsed(
         message: &str,
         method: Option<Range<usize>>,
@@ -175,15 +179,6 @@ impl Default for PartialHttpRequest {
     }
 }
 
-impl FromStr for PartialHttpRequest {
-    type Err = Error;
-
-    /// Parse a string in to a partial request
-    fn from_str(s: &str) -> Result<Self, Self::Err> {
-        parse_request(s, parse_first_line)
-    }
-}
-
 type FirstLineParts = (
     Option<Range<usize>>,
     Option<Range<usize>>,

tests/display_tests.rs

@@ -1,4 +1,4 @@
-use std::{fs, str::FromStr};
+use std::fs;
 
 use http_message::PartialHttpRequest;
 

tests/parse_tests.rs

@@ -1,5 +1,3 @@
-use std::str::FromStr;
-
 use http_message::PartialHttpRequest;
 use http_message::models::{request::HttpRequest, uri::Uri};