Improve typechecking for identifiers that are builtins

Author: kyleect

spec/invalid/not_id.expr.disassembled

@@ -1,5 +1,11 @@
-VERSION 0700
-----
-0000 GET BUILTIN        16 == 'not'
-0003 GET BUILTIN         0 == 'id'
-0006 CALL             (1 args)
+[
+    (
+        CompileError(
+            TypeMismatch {
+                expected: Bool,
+                actual: Fn(Value) -> Value,
+            },
+        ),
+        5..7,
+    ),
+]

spec/invalid/not_id.expr.interpreted

@@ -1,11 +1,11 @@
 [
     (
-        RuntimeError(
+        CompileError(
             TypeMismatch {
                 expected: Bool,
                 actual: Fn(Value) -> Value,
             },
         ),
-        0..0,
+        5..7,
     ),
 ]

src/ast.rs

@@ -50,7 +50,11 @@ impl Expr {
     pub fn get_type(&self) -> Type {
         match self {
             Expr::Bool(_) => Type::Bool,
-            Expr::Identifier(_) => Type::Unknown,
+            Expr::Identifier(identifier) => identifier
+                .get_type()
+                .as_ref()
+                .unwrap_or(&Type::Unknown)
+                .clone(),
             Expr::Call(_) => Type::Unknown,
             Expr::String(_) => Type::String,
             Expr::Error => Type::Unknown,

src/errors.rs

@@ -498,7 +498,7 @@ pub mod diagnostics {
 
             assert_eq!(diagnostics.len(), 1);
             let diagnostic = &diagnostics[0];
-            assert_eq!(diagnostic.code, Some("".to_string()));
+            assert_eq!(diagnostic.code, Some("lexical".to_string()));
             assert_eq!(diagnostic.message, "Invalid token".to_string());
             assert_eq!(diagnostic.severity, Severity::Error);
             assert_eq!(diagnostic.labels.len(), 1);
@@ -514,7 +514,7 @@ pub mod diagnostics {
 
             assert_eq!(diagnostics.len(), 1);
             let diagnostic = &diagnostics[0];
-            assert_eq!(diagnostic.code, Some("".to_string()));
+            assert_eq!(diagnostic.code, Some("compiler".to_string()));
             assert_eq!(diagnostic.message, "undefined: var".to_string());
             assert_eq!(diagnostic.severity, Severity::Error);
             assert_eq!(diagnostic.labels.len(), 1);
@@ -533,7 +533,7 @@ pub mod diagnostics {
 
             assert_eq!(diagnostics.len(), 1);
             let diagnostic = &diagnostics[0];
-            assert_eq!(diagnostic.code, Some("".to_string()));
+            assert_eq!(diagnostic.code, Some("compiler".to_string()));
             assert_eq!(
                 diagnostic.message,
                 "expects 2 arguments but received 3".to_string()