Skip to content

Fix sporadic failure for “firstTimeOnly” methods #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krmahadevan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix sporadic failure for “firstTimeOnly” methods #2850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions testng-core-api/src/main/java/org/testng/ITestResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,13 @@ default List<ITestNGMethod> getSkipCausedBy() {
*/
String id();

/**
* @return <code>true</code> if the current method (test|configuration) was executed by TestNG.
*/
default boolean wasExecuted() {
return !isNotRunning();
}

/**
* @return - <code>true</code> if the current test result is either {@link ITestResult#STARTED} or
* {@link ITestResult#CREATED}
Expand Down
11 changes: 8 additions & 3 deletions testng-core/src/main/java/org/testng/internal/invokers/ConfigInvoker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,18 +285,23 @@ public void invokeConfigurations(ConfigMethodArguments arguments) {
arguments.getTestMethodResult());
testResult.setParameters(parameters);

runConfigurationListeners(testResult, arguments.getTestMethod(), true /* before */);

Object newInstance = computeInstance(arguments.getInstance(), inst, tm);
if (isConfigMethodEligibleForScrutiny(tm)) {
if (m_executedConfigMethods.add(arguments.getTestMethod())) {
runConfigurationListeners(testResult, arguments.getTestMethod(), true /* before */);
invokeConfigurationMethod(newInstance, tm, parameters, testResult);
}
} else {
runConfigurationListeners(testResult, arguments.getTestMethod(), true /* before */);
invokeConfigurationMethod(newInstance, tm, parameters, testResult);
}
copyAttributesFromNativelyInjectedTestResult(parameters, arguments.getTestMethodResult());
runConfigurationListeners(testResult, arguments.getTestMethod(), false /* after */);

if (testResult.wasExecuted()) {
// When it comes to "firstTimeOnly" configurations, some of them would NOT be run
// by TestNG. For those occurrences, DONOT run the listener.
runConfigurationListeners(testResult, arguments.getTestMethod(), false /* after */);
}
if (testResult.getStatus() == ITestResult.SKIP) {
Throwable t = testResult.getThrowable();
if (t != null) {
Expand Down