Conversation
…tion #359 Remove manual pthread link flag detection and LDFLAGS modification. Rely on standard AX_PTHREAD substitutions for CC and LIBS, and exclude PTHREAD_CFLAGS from CPPFLAGS to avoid redundancy.
There was a problem hiding this comment.
Pull request overview
Updates the Autotools configuration to simplify pthread handling (per Issue #359) by removing custom link-flag detection and relying more directly on AX_PTHREAD outputs.
Changes:
- Removed manual detection of
-pthread/-pthreadsinPTHREAD_CFLAGSand the correspondingLDFLAGSmodification. - Kept
AX_PTHREAD-provided substitutions forCCandLIBS. - Stopped appending
PTHREAD_CFLAGSintoCPPFLAGSto avoid redundancy.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion #359
Remove manual pthread link flag detection and LDFLAGS modification.
Rely on standard AX_PTHREAD substitutions for CC and LIBS, and exclude PTHREAD_CFLAGS from CPPFLAGS to avoid redundancy.