chore[notask]: migrate classification wrapper to TypeScript#3192
Open
yuranich wants to merge 4 commits into
Open
chore[notask]: migrate classification wrapper to TypeScript#3192yuranich wants to merge 4 commits into
yuranich wants to merge 4 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Shouldn't add this file under "files" in package.json?
Contributor
Author
There was a problem hiding this comment.
we can but not really needed as it is not part of public API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
@qvac/classification-ggmlkeeps its runtime wrapper and TypeScript declarations as separate hand-maintained files, which can drift as the addon API changes. This PoC validates a full addon migration path where sources are authored in TypeScript while the package still publishes JavaScript entrypoints for SDK and Bare consumers.How does it solve it?
Adds TypeScript-authored wrapper sources, generated root JavaScript and declarations, package scripts that typecheck and assert generated output freshness, SDK-aligned TypeScript ESLint rules for addon source, publish jobs that rebuild the wrapper before publishing, and a small Bare example using the existing classification test image.
Validation run locally:
npm run lint,npm run test:types,npm run test:dts,npm run test:unit,npm pack --dry-run, andgit diff --check -- packages/classification-ggml .github/workflows/on-merge-classification-ggml.yml.npm run test:integrationwas attempted locally but is blocked by missing native prebuilds (ADDON_NOT_FOUNDfrombinding.js). The new Bare example was later run successfully against local prebuilds and returnedfoodas the top classification formeal_1.jpg.Breaking changes
None expected. Runtime package entrypoints remain JavaScript.