Skip to content

Fixes in Tethys CLI for Creating THREDDS Services#1272

Merged
swainn merged 9 commits into
mainfrom
spatial-dataset-cli-fix
Jun 16, 2026
Merged

Fixes in Tethys CLI for Creating THREDDS Services#1272
swainn merged 9 commits into
mainfrom
spatial-dataset-cli-fix

Conversation

@jakeymac

@jakeymac jakeymac commented May 15, 2026

Copy link
Copy Markdown
Contributor

Description

This merge request addresses an inconsistency in the CLI command for creating a spatial dataset service. This addresses issues in creating THREDDS services as they don't often require usernames and passwords that are a required part of the connection argument.

Changes Made to Code

  • Made the connection argument no longer required
  • Added an endpoint requirement to be used instead of including the endpoint in a connection argument.

Quality Checks

  • At least one new test has been written for new code
  • New code has 100% test coverage
  • Code has been formatted with Black
  • Code has been linted with flake8
  • Docstrings for new methods have been added
  • The documentation has been updated appropriately

@coveralls

coveralls commented May 15, 2026

Copy link
Copy Markdown

Coverage Status

No base build to compare — spatial-dataset-cli-fix into main

Comment thread tethys_cli/services_commands.py
@jakeymac jakeymac requested a review from swainn May 28, 2026 20:40
@swainn swainn merged commit a4dec84 into main Jun 16, 2026
38 checks passed
@swainn swainn deleted the spatial-dataset-cli-fix branch June 16, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants