fix: etcd fails due to unaccounted space usage (e.g. WAL)

[cwrau]

This way the real volume usage is looked at and used for resizing.

[gemini-code-assist]

Code Review

This pull request introduces a new EtcdVolumeStatsProvider to monitor and reconcile etcd volume usage by querying kubelet stats, allowing for more accurate tracking of disk usage beyond just the etcd database size. It includes updates to the etcd client to support filtering by ready pods, improvements to the etcd cluster reconciler to incorporate filesystem usage metrics, and necessary dependency updates. I have no feedback to provide.

[Copilot]

Pull request overview

This PR fixes etcd volume auto-resize logic by using actual filesystem usage (via kubelet stats summary) instead of relying solely on etcd-reported DB size, accounting for extra space usage like WAL/snapshot files.

Changes:

• Add an etcd volume stats provider that queries kubelet /stats/summary and computes max etcd volume usage across pods.
• Update the etcd cluster reconciler to compute an “effective” volume usage as max(dbSize, filesystemUsage) and emit warnings when they diverge significantly.
• Update etcd status collection to target ready pods and parallelize member calls; adjust wiring, stubs, and tests accordingly.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
test/etcd_stubs.go	Updates etcd client stub signature and adds a stub for the new volume stats provider.
pkg/reconcilers/etcd_cluster/volume_stats/volume_stats.go	Implements kubelet-based filesystem usage collection for etcd data volumes.
pkg/reconcilers/etcd_cluster/volume_stats/volume_stats_test.go	Adds unit tests for volume identification (isEtcdDataVolume).
pkg/reconcilers/etcd_cluster/reconciler.go	Integrates filesystem usage into resize decisions; adds pod listing and adjusts health check placement and args gating.
pkg/reconcilers/etcd_cluster/reconciler_test.go	Extends tests for new effective-usage and warning behaviors.
pkg/reconcilers/etcd_cluster/etcd_client/etcd_client.go	Changes GetStatuses API to accept ready pod names and parallelizes per-member calls.
pkg/hostedcontrolplane/controller.go	Wires the new volume stats provider into the reconciler; adjusts events RBAC verbs.
go.mod	Bumps several dependencies (k8s libs, controller-runtime, grpc, cilium).
go.sum	Updates checksums for dependency upgrades.
.golangci.yaml	Adds import aliasing for kubelet stats API package.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 33 out of 35 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 33 out of 35 changed files in this pull request and generated 1 comment.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.