fix: don't set NODE_IP for kubeproxy, otherwise it fails without cloud provider#27
Merged
Merged
Conversation
…d provider This can happen during bootstrapping as well as when the provider is down for some reason.
cwrau
enabled auto-merge (squash)
October 17, 2025 14:47
There was a problem hiding this comment.
Pull Request Overview
This PR removes NODE_IP environment variable dependencies from the kubeproxy configuration to prevent failures when cloud providers are unavailable during bootstrapping or downtime.
- Removes NODE_IP environment variable and bind-address argument that depends on it
- Removes nodeport-addresses command line argument in favor of configuration in the config map
- Adds NodePortAddresses configuration directly to the kubeproxy config map
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Oct 17, 2025
This was referenced Nov 25, 2025
This was referenced May 28, 2026
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can happen during bootstrapping as well as when the provider is
down for some reason.