chore: migrate to new CAPI contract#30
Merged
Merged
Conversation
cwrau
enabled auto-merge (squash)
October 20, 2025 14:33
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the codebase to use the new Cluster API (CAPI) contract by updating the status structure for hosted control planes. The changes align with CAPI v1beta2 requirements for control plane providers.
- Replaced direct
Initializedboolean field with nestedInitialization.ControlPlaneInitializedpointer field - Added
UpToDateReplicasstatus field to match CAPI contract requirements - Updated test assertions and kubebuilder annotations to reflect new status structure
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| api/v1alpha1/hostedcontrolplane_types.go | Updated HostedControlPlaneStatus to use nested Initialization struct with pointer field instead of direct boolean; added UpToDateReplicas field |
| api/v1alpha1/zz_generated.deepcopy.go | Auto-generated deepcopy methods for new HostedControlPlaneInitializationStatus type |
| pkg/reconcilers/workload/reconciler.go | Updated code to set Initialization.ControlPlaneInitialized using ptr.To(true) |
| pkg/reconcilers/apiserverresources/apiserverresources.go | Added assignment of UpToDateReplicas from deployment status |
| pkg/hostedcontrolplane/lifecycle_phases_test.go | Updated test assertion to check nested Initialization.ControlPlaneInitialized pointer field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cwrau
added a commit
that referenced
this pull request
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.