Skip to content

fix: use Status.WARN instead of ERROR#6

Merged
3w36zj6 merged 1 commit into
mainfrom
feature/fix-output-error
Mar 22, 2025
Merged

fix: use Status.WARN instead of ERROR#6
3w36zj6 merged 1 commit into
mainfrom
feature/fix-output-error

Conversation

@3w36zj6

@3w36zj6 3w36zj6 commented Mar 21, 2025

Copy link
Copy Markdown
Member

This PR is a cherry-pick of taichi/vscode-textlint#67.

If ERROR is set to ERROR, the OUTPUT panel opens, so use WARNING instead.

This PR changes the behaviour when opening a project without textlint installed.

- If ERROR is set to ERROR, the OUTPUT panel opens, so use WARNING instead.
@3w36zj6 3w36zj6 added the Type: Bug Bug or Bug fixes label Mar 22, 2025
@3w36zj6

3w36zj6 commented Mar 22, 2025

Copy link
Copy Markdown
Member Author

I think this PR is fine, but may I merge it, @azu?

In the original PR comment, it was suggested that we shouldn't look for the executable when there's no .textlintrc file, but I think this can be handled in a separate Issue/PR.

@azu azu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azu

azu commented Mar 22, 2025

Copy link
Copy Markdown
Member

In the original PR comment, it was suggested that we shouldn't look for the executable when there's no .textlintrc file, but I think this can be handled in a separate Issue/PR.

I agree.

@3w36zj6 3w36zj6 merged commit 15f4bce into main Mar 22, 2025
@3w36zj6 3w36zj6 deleted the feature/fix-output-error branch March 22, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Bug or Bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants