Don't overwrite $label in loops. Damn you, extract()

Bloke · Bloke · commit 107a24caf5a0 · 2017-03-15T09:06:36.000Z
Thanks, trenc. Fixes issue #49.
diff --git a/zem_contact_reborn.php b/zem_contact_reborn.php
@@ -488,13 +488,13 @@ function zem_contact($atts, $thing = null)
         $msg = array();
         $fields = array();
 
-        foreach ($zem_contact_labels as $name => $label) {
+        foreach ($zem_contact_labels as $name => $lbl) {
             if (!is_array($zem_contact_values[$name])) {
                 if (trim($zem_contact_values[$name]) === false) {
                     continue;
                 }
 
-                $msg[] = $label . ': ' . $zem_contact_values[$name];
+                $msg[] = $lbl . ': ' . $zem_contact_values[$name];
             }
 
             $fields[$name] = $zem_contact_values[$name];

Original file line number	Diff line number	Diff line change
`@@ -488,13 +488,13 @@ function zem_contact($atts, $thing = null)`
`488`	`488`	`$msg = array();`
`489`	`489`	`$fields = array();`
`490`	`490`
`491`		`- foreach ($zem_contact_labels as $name => $label) {`
	`491`	`+ foreach ($zem_contact_labels as $name => $lbl) {`
`492`	`492`	`if (!is_array($zem_contact_values[$name])) {`
`493`	`493`	`if (trim($zem_contact_values[$name]) === false) {`
`494`	`494`	`continue;`
`495`	`495`	`}`
`496`	`496`
`497`		`- $msg[] = $label . ': ' . $zem_contact_values[$name];`
	`497`	`+ $msg[] = $lbl . ': ' . $zem_contact_values[$name];`
`498`	`498`	`}`
`499`	`499`
`500`	`500`	`$fields[$name] = $zem_contact_values[$name];`