Correct types in PyModuleDef / fix compilation with new clang+gcc#26
Open
hannob wants to merge 1 commit into
Open
Correct types in PyModuleDef / fix compilation with new clang+gcc#26hannob wants to merge 1 commit into
hannob wants to merge 1 commit into
Conversation
https://docs.python.org/3/c-api/module.html#c.PyModuleDef Fixes compilation with clang.
|
@tgalal could you please review? Currently, it is not possible to build |
|
I had the following error with Python 3.11 and this change solved the problem: |
|
This patch also fixes the build with GCC 14. Would be great if it could be merged. |
hannob
changed the title
setarcos
added a commit
to lcpu-club/loongarch-packages
that referenced
this pull request
Sep 2, 2024
fix error: incompatible pointer to integer conversion patch already available, but not merged: tgalal/python-axolotl-curve25519#26
|
Any news? |
|
Until this is merged, this is the workaround. I installed the patch manually using: Then using the following works fine: And if the project have other requirements (ehm ehm yowsup): Saved you 10 minutes of stackoverflowing, yw. |
13 tasks
|
Used this fix and published a package with pre-built wheels for the most platforms as a fork here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 4th variable of PyModuleDef is an int, not a pointer:
https://docs.python.org/3/c-api/module.html#c.PyModuleDef
Fixes compilation with clang.