fix(tui): allow disposable transient views in RegisterView#16
Merged
Conversation
Views derive from Window (IDisposable). DryIoc throws RegisteredDisposableTransientWontBeDisposedByContainer when a disposable type is registered as a transient, so resolving the application host and navigating to the first screen crashed at startup. Register the view with Setup.With(allowDisposableTransient: true): the view host already disposes each view on Remove, so the container must not also track/dispose it. Add a regression test registering a disposable view through RegisterView.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| [Fact] | ||
| public void RegisterView_AllowsDisposableTransientView() | ||
| { | ||
| var container = new Container(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running the TUI sample crashed at startup with:
TuiView<T>derives from Terminal.GuiWindow, which isIDisposable.RegisterView<TView,TViewModel>()registered the view asReuse.Transient, and DryIoc refuses disposable transients by default. This affected every view (imperative and DSL alike); it only surfaced now because the sample had never been run (build-verified only).Fix
Register the view with
Setup.With(allowDisposableTransient: true). The view host already disposes each view onRemove(TerminalGuiViewHost.Remove→view.Dispose()), so the container must not also track/dispose it —allow(nottrack) avoids a double-dispose.Added a regression test that registers a disposable
ITuiViewthroughRegisterViewand asserts it resolves without throwing (the existing test used a non-disposable fake, which is why it never caught this).Test plan
RegisterTuiExtensionsTestsgreen (3/3, incl. the new disposable case)SquidStd.Tuibuilds (0 errors)dotnet runof the sample now launches past registration (please confirm in a real terminal)