test(core): stabilise flaky FileWatcher debounce test#17
Merged
Conversation
Watch_RapidWritesToSameFile_DebouncesToSingleEvent assumed five rapid writes fall inside one 200ms debounce window; on a loaded CI runner a scheduler/GC pause between writes split the burst across two windows, emitting two events and failing Assert.Single. Use a 1s debounce window for this test and a tight synchronous write loop so the burst reliably collapses to a single event without weakening the assertion's intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI failed on an unrelated, pre-existing flaky test:
The test does five rapid writes and expects the 200ms debounce to collapse them into one
FileChangedEvent. On a loaded CI runner, a scheduler/GC pause >200ms between writes splits the burst across two debounce windows → two events →Assert.Singlefails. It is a test-timing race, not a product bug; the FileWatcher debounce works correctly.Fix
For this test only: use a 1s debounce window and a tight synchronous write loop (no
awaitpoints the scheduler can preempt mid-burst), so the five writes reliably land in one window. The assertion's intent (rapid writes collapse to a single event) is unchanged.Test plan
FileWatcherServiceTestsgreen across 3 consecutive local runs (7/7 each)