feat(templating): support {{ include }} in Scriban templates#28
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public async Task Include_AutoLoadedFromDisk_Works() | ||
| { | ||
| using var temp = new TempDirectory(); | ||
| var templatesDir = Path.Combine(temp.Path, "templates"); |
| { | ||
| using var temp = new TempDirectory(); | ||
| var templatesDir = Path.Combine(temp.Path, "templates"); | ||
| Directory.CreateDirectory(Path.Combine(templatesDir, "partials")); |
| using var temp = new TempDirectory(); | ||
| var templatesDir = Path.Combine(temp.Path, "templates"); | ||
| Directory.CreateDirectory(Path.Combine(templatesDir, "partials")); | ||
| await File.WriteAllTextAsync(Path.Combine(templatesDir, "partials", "header.tmpl"), "HEADER"); |
| Directory.CreateDirectory(Path.Combine(templatesDir, "partials")); | ||
| await File.WriteAllTextAsync(Path.Combine(templatesDir, "partials", "header.tmpl"), "HEADER"); | ||
| await File.WriteAllTextAsync( | ||
| Path.Combine(templatesDir, "page.tmpl"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables
{{ include 'name' }}in SquidStd.Templating. Previously the renderer usedTemplate.RenderAsync(model), which builds a defaultTemplateContextwith noTemplateLoader, so anyincludefailed at runtime ("No TemplateLoader registered").Includes now resolve from the registered templates — the same namespace as
RenderByNameAsync, including thetemplates/**/*.tmplauto-loaded at startup ({{ include 'partials/header' }}→templates/partials/header.tmpl). In-memory, no render-time I/O, no path-traversal surface.Changes
NamedTemplateLoader(Internal): a ScribanITemplateLoaderserving registered template sources; missing name →TemplateException.ScribanTemplateRenderer: keeps aname → sourcemap (_sources), renders via aTemplateContextwith the loader set. Model binding preserved (same default member renamer as before). Both inline and by-name renders can include registered templates.Test Plan
TemplateException; include across auto-loaded.tmplfiles (5 new tests)