feat(bootstrap): lifecycle logging with AppName, versions and registration summary#46
Merged
Merged
Conversation
…ssert.Contains in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bootstrap was silent: nothing on service start, nothing on shutdown, no trace of registrations, and a start failure propagated without naming the service. Now the whole lifecycle is logged:
SquidStdOptions.AppName(defaults to the entry assembly name) + app/SquidStd versions fromInformationalVersion; attached to every event asApplication/ApplicationVersionenrichment.StopAsynclogs a Warning and the remaining services are still stopped (was: aborted the loop, leaving them running); cancellation still rethrows.ILogEventSinkinstances registered in the container are attached to the bootstrap logger (extension point + what makes these tests possible).Follow-ups noted (out of scope)
StartAsynccalled twice re-starts every service (the GettingStarted sample doesStartAsync+RunAsync);MarkStartingshould guard it.Stopped); acceptable, documented behavior.Test Plan