Skip to content

Commit 8e75c46

Browse files
that-github-userunknownclaude
authored
Fix CI test failure and add GitHub Packages publishing (#161)
* Fix CI test failure and add GitHub Packages publishing - Fix exit-127 preflight test: accept both "Test command not found" and generic failure message (Linux returns 127, Windows may differ) - Add GitHub Packages publish step to release workflow: publishes as @that-github-user/thinktank-ai to npm.pkg.github.com alongside the existing npmjs.org publish - Add packages:write permission to release workflow Fixes CI failure from #160. Resolves "No packages published" on GitHub. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix formatting (trailing comma) * Remove accidentally committed artifacts, update .gitignore --------- Co-authored-by: unknown <that-github-user@github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent ca6e68f commit 8e75c46

3 files changed

Lines changed: 25 additions & 2 deletions

File tree

.github/workflows/release.yml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88
permissions:
99
contents: write
1010
id-token: write
11+
packages: write
1112

1213
jobs:
1314
release:
@@ -36,11 +37,24 @@ jobs:
3637
- name: Test
3738
run: npm test
3839

39-
- name: Publish to npm (trusted publishing via OIDC)
40+
- name: Publish to npm
4041
run: npm publish --provenance --access public
4142
env:
4243
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
4344

45+
- name: Configure GitHub Packages registry
46+
uses: actions/setup-node@v4
47+
with:
48+
node-version: 22
49+
registry-url: https://npm.pkg.github.com/
50+
51+
- name: Publish to GitHub Packages
52+
run: |
53+
npm pkg set "name=@that-github-user/thinktank-ai"
54+
npm publish --access public
55+
env:
56+
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
57+
4458
- name: Create GitHub Release
4559
uses: softprops/action-gh-release@v2
4660
with:

.gitignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,8 @@ node_modules/
22
dist/
33
.thinktank/
44
*.tgz
5+
6+
__pycache__/
7+
*.pyc
8+
examples/*/package-lock.json
9+
scripts/batch-runs*.sh

src/commands/run.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,6 +465,10 @@ describe("preflightTestRun", () => {
465465
it("returns warning when command is not found", async () => {
466466
const result = await preflightTestRun("nonexistent-command-xyz", process.cwd());
467467
assert.ok(result);
468-
assert.ok(result.includes("failed on the current branch"));
468+
// Exit 127 (command not found) gets a specific message
469+
assert.ok(
470+
result.includes("Test command not found") || result.includes("failed on the current branch"),
471+
`Expected exit-127 or generic failure message, got: ${result.substring(0, 100)}`,
472+
);
469473
});
470474
});

0 commit comments

Comments
 (0)