Skip to content

Dead code: extractRunNumber always returns -1 #130

@that-github-user

Description

@that-github-user

Description

extractRunNumber in src/commands/list.ts:18-20 always returns -1:

export function extractRunNumber(_filename: string): number {
  return -1; // Assigned by loadAllRuns based on sort position
}

Run numbers are actually assigned by loadAllRuns() using array index (buildRunSummary(i + 1, r.result)), making this function dead code. It's only imported in list.test.ts.

Suggested fix

Remove extractRunNumber entirely and update its tests. If filename-based extraction is needed in the future, implement it properly at that time.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions