Fix DEP0190: remove all execFile+shell:true usage#147
Merged
Conversation
Replace execFile(cmd, args, {shell:true}) with exec(cmdString) in
test-runner.ts and run.ts preflightTestRun. The shell:true+args pattern
is deprecated (DEP0190) because args aren't escaped, making it equivalent
to string concatenation. Since we validate commands via validateTestCommand
before execution, using exec directly is both safer and more honest.
Closes #135
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
execFile(cmd, args, {shell:true})withexec(cmdString)in:src/scoring/test-runner.ts— test executionsrc/commands/run.ts— preflight test runThe
shell:true+ args pattern is deprecated (Node.js DEP0190) because args aren't escaped when shell mode is used. Since we validate commands viavalidateTestCommand()before execution, usingexec()directly is both safer (no false security from args array) and eliminates the deprecation warning.This is a pre-publish security fix — needed before npm release (#139/#146).
Change type
Related issue
Closes #135
How to test
Breaking changes
🤖 Generated with Claude Code