Code quality: remove dead code, deduplicate padRight, clean exports#148
Merged
Conversation
- Remove extractRunNumber (always returned -1, dead code) (#130) - Import padRight from display.ts instead of duplicating in evaluate.ts (#132) - Make CleanOptions, CompareOptions, StatsOptions non-exported (unused externally) (#133) - Keep ApplyOptions exported (used in tests) Closes #130 Closes #132 Closes #133 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractRunNumber()— always returned -1 (Dead code: extractRunNumber always returns -1 #130)padRightfrom display.ts instead of duplicating in evaluate.ts (Duplicated padRight in evaluate.ts — should import from display.ts #132)CleanOptions,CompareOptions,StatsOptionsnon-exported (Remove unnecessary interface exports (ApplyOptions, CleanOptions, StatsOptions, CompareOptions) #133)Change type
Related issue
Closes #130, #132, #133
How to test
Breaking changes
🤖 Generated with Claude Code