Commit 05687a8
committed
fix(ci): resolve 4 simple code quality issues (Round 1)
Applying minimal fixes following fix-ci-loop methodology:
1. Dependency Review Workflow:
- Fixed: Cannot use both allow-licenses and deny-licenses
- Removed allow-licenses parameter
- Kept deny-licenses for GPL/AGPL restrictions
2. pkg/security/validation_test.go:666:
- Fixed: undefined: strings
- Added missing "strings" import
3. pkg/websocket/server.go:123:
- Fixed: Context cancel function not used on all paths
- Added defer cancel() after context creation
4. examples/claude_cli_demo.go:24:
- Fixed: fmt.Println arg list ends with redundant newline
- Replaced "\n" in string with explicit fmt.Println()
Files Modified:
- .github/workflows/dependency-review.yml
- examples/claude_cli_demo.go
- pkg/security/validation_test.go
- pkg/websocket/server.go
Expected Impact:
- Dependency Review workflow should now pass
- 4 go vet errors resolved
- Remaining: ~17 errors (mostly in tn/manager and adapters/vnf-operator)
Next Round: Will address test redeclarations and undefined methods1 parent df1b6f9 commit 05687a8
4 files changed
Lines changed: 5 additions & 4 deletions
File tree
- .github/workflows
- examples
- pkg
- security
- websocket
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
51 | 49 | | |
52 | 50 | | |
53 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| 124 | + | |
124 | 125 | | |
125 | 126 | | |
126 | 127 | | |
| |||
0 commit comments